From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934976AbcHaOBe (ORCPT ); Wed, 31 Aug 2016 10:01:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38990 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934044AbcHaOBa (ORCPT ); Wed, 31 Aug 2016 10:01:30 -0400 Date: Wed, 31 Aug 2016 16:01:38 +0200 From: Greg KH To: xinhui Cc: "linux-kernel@vger.kernel.org" , Jiri Slaby , yanmin_zhang@linux.intel.com, alan@linux.intel.com Subject: Re: [PATCH V2 RESEND] tty/n_gsm.c: use gsm->num to remove mux itself from gsm_mux[] Message-ID: <20160831140138.GA13669@kroah.com> References: <57874F5F.5050000@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57874F5F.5050000@linux.vnet.ibm.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 04:37:51PM +0800, xinhui wrote: > From: Pan Xinhui > > There is one filed gsm->num to store mux's index of gsm_mux[]. So use > gsm->num to remove itself from gsm_mux[] instead of the for-loop > traverse in gsm_cleanup_mux(). > > Signed-off-by: Pan Xinhui > Reviewed-by: Alan Cox > --- > change from V1: > lock is also held for the if() > --- > drivers/tty/n_gsm.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) Doesn't apply to my tree :(