Re: [PATCH v3 2/2] dmi-id: add dmi/id/oem group for exporting oem strings to sysfs

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Aug 31, 2016 at 02:01:23PM +0000, Mario_Limonciello@Dell.com wrote:
> Hi Greg,
> 
> > -----Original Message-----
> > From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org]
> > Sent: Wednesday, August 31, 2016 7:40 AM
> > To: Hung, Allen <Allen_Hung@Dell.com>
> > Cc: Jean Delvare <jdelvare@suse.com>; Russell King
> > <rmk+kernel@arm.linux.org.uk>; Gabriel Somlo <somlo@cmu.edu>; Bjorn
> > Andersson <bjorn.andersson@sonymobile.com>; Jens Wiklander
> > <jens.wiklander@linaro.org>; Andy Gross <agross@codeaurora.org>; Arnd
> > Bergmann <arnd@arndb.de>; Sudeep Holla <sudeep.holla@arm.com>; Eric
> > Anholt <eric@anholt.net>; linux-kernel@vger.kernel.org; Limonciello, Mario
> > <Mario_Limonciello@Dell.com>
> > Subject: Re: [PATCH v3 2/2] dmi-id: add dmi/id/oem group for exporting oem
> > strings to sysfs
> > 
> > On Mon, Aug 15, 2016 at 05:22:05PM +0800, Allen Hung wrote:
> > > The oem strings in DMI system identification information of the BIOS
> > > have been parsed and stored as dmi devices in dmi_scan.c but they are
> > > not exported to userspace via sysfs.
> > >
> > > The patch intends to export oem strings to sysfs device /sys/class/dmi/id.
> > > As the number of oem strings are dynamic, a group "oem" is added to
> > > the device and the strings will be added to the group as string1,
> > > string2, ..., and stringN.
> > >
> > > Signed-off-by: Allen Hung <allen_hung@dell.com>
> > > ---
> > >  drivers/firmware/Kconfig  |   9 ++++
> > >  drivers/firmware/dmi-id.c | 116
> > > ++++++++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 125 insertions(+)
> > >
> > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index
> > > 6664f11..885a6c9 100644
> > > --- a/drivers/firmware/Kconfig
> > > +++ b/drivers/firmware/Kconfig
> > > @@ -119,6 +119,15 @@ config DMIID
> > >  	  information from userspace through /sys/class/dmi/id/ or if you want
> > >  	  DMI-based module auto-loading.
> > >
> > > +config DMIID_OEM_STRINGS
> > > +	bool "Export OEM strings in SMBIOS/DMI via sysfs to userspace"
> > > +	depends on DMIID
> > > +	default n
> > > +	help
> > > +	  Say Y here if you want to query OEM strings (as part of the information
> > > +	  contained in SMBIOS/DMI system identification) from userspace
> > through
> > > +	  /sys/class/dmi/id/oem/.
> > 
> > Why wouldn't you want these?
> > 
> 
> Jean Delvare would rather see this implemented in userspace dmidecode.
> Jean raised a concern in an earlier submission that this runs on every
> machine (https://lkml.org/lkml/2016/8/2/799).

Ah, yeah, just use dmidecode, much simpler, keeps the kernel smaller, I
like it.

thanks,

greg k-h