From: Stephen Hemminger <stephen@networkplumber.org>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: <viktorin@rehivetech.com>, <dev@dpdk.org>, <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 2/5] eal: extract function eal_parse_sysfs_valuef
Date: Wed, 31 Aug 2016 23:30:10 -0700 [thread overview]
Message-ID: <20160831233010.5d78d262@xeon-e3> (raw)
In-Reply-To: <1472704915-13112-3-git-send-email-shreyansh.jain@nxp.com>
On Thu, 1 Sep 2016 10:11:52 +0530
Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> From: Jan Viktorin <viktorin@rehivetech.com>
>
> From: Jan Viktorin <viktorin@rehivetech.com>
>
> The eal_parse_sysfs_value function accepts a filename however, such
> interface introduces race-conditions to the code. Introduce the
> variant of this function that accepts an already opened file instead of
> a filename.
>
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
You introduce new API, but don't use it in your other patches.
I don't see where passing filename is racy. sysfs files only get created/destroyed
when device is added/removed.
next prev parent reply other threads:[~2016-09-01 6:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 4:41 [PATCH 0/5] Generalize PCI specific EAL function/structures Shreyansh Jain
2016-09-01 4:41 ` [PATCH 1/5] eal: make enum rte_kernel_driver non-PCI specific Shreyansh Jain
2016-09-11 12:15 ` Yuanhan Liu
2016-09-12 5:10 ` Shreyansh Jain
2016-09-01 4:41 ` [PATCH 2/5] eal: extract function eal_parse_sysfs_valuef Shreyansh Jain
2016-09-01 6:30 ` Stephen Hemminger [this message]
2016-09-01 9:01 ` Shreyansh Jain
2016-09-01 4:41 ` [PATCH 3/5] eal: Convert pci_(un)map_resource to rte_eal_(un)map_resource Shreyansh Jain
2016-09-01 4:41 ` [PATCH 4/5] eal/linux: extract function rte_eal_unbind_kernel_driver Shreyansh Jain
2016-09-01 4:41 ` [PATCH 5/5] eal/linux: extract function rte_eal_get_kernel_driver_by_path Shreyansh Jain
2016-09-27 14:12 ` [PATCH v1 0/4] Generalize PCI specific EAL function/structures Shreyansh Jain
2016-09-27 14:12 ` [PATCH v1 1/4] eal: generalize PCI kernel driver enum to EAL Shreyansh Jain
2016-09-27 14:12 ` [PATCH v1 2/4] eal: generalize PCI map/unmap resource " Shreyansh Jain
2016-09-27 14:12 ` [PATCH v1 3/4] eal/linux: generalize PCI kernel unbinding driver " Shreyansh Jain
2016-09-27 14:12 ` [PATCH v1 4/4] eal/linux: generalize PCI kernel driver extraction " Shreyansh Jain
2016-09-30 15:31 ` [PATCH v1 0/4] Generalize PCI specific EAL function/structures David Marchand
2016-10-03 5:37 ` Shreyansh Jain
2016-10-03 13:12 ` Jan Viktorin
2016-10-03 13:36 ` Thomas Monjalon
2016-10-06 11:43 ` Shreyansh Jain
2016-10-06 13:01 ` Thomas Monjalon
2016-10-13 6:47 ` Shreyansh Jain
2016-10-14 10:55 ` [PATCH v2 " Shreyansh Jain
2016-10-14 10:55 ` [PATCH v2 1/4] eal: generalize PCI kernel driver enum to EAL Shreyansh Jain
2016-10-14 10:55 ` [PATCH v2 2/4] eal: generalize PCI map/unmap resource " Shreyansh Jain
2016-10-14 10:55 ` [PATCH v2 3/4] eal/linux: generalize PCI kernel unbinding driver " Shreyansh Jain
2016-10-14 10:55 ` [PATCH v2 4/4] eal/linux: generalize PCI kernel driver extraction " Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831233010.5d78d262@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
--cc=thomas.monjalon@6wind.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.