From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:44755 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbcIAIqZ (ORCPT ); Thu, 1 Sep 2016 04:46:25 -0400 Date: Thu, 1 Sep 2016 10:46:24 +0200 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , axboe@fb.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH 4/7] blk-mq: allow the driver to pass in an affinity mask Message-ID: <20160901084624.GC4115@lst.de> References: <1472468013-29936-1-git-send-email-hch@lst.de> <1472468013-29936-5-git-send-email-hch@lst.de> <20160831163852.GB5598@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160831163852.GB5598@localhost.localdomain> Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Wed, Aug 31, 2016 at 12:38:53PM -0400, Keith Busch wrote: > This can't be right. We have a single affinity mask for the entire > set, but what I think we want is an one affinity mask for each > nr_io_queues. The irq_create_affinity_mask should then create an array > of cpumasks based on nr_vecs.. Nah, this is Thomas' creating abuse of the cpumask type. Every bit set in the affinity_mask means this is a cpu we allocate a vector / queue to. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hch@lst.de (Christoph Hellwig) Date: Thu, 1 Sep 2016 10:46:24 +0200 Subject: [PATCH 4/7] blk-mq: allow the driver to pass in an affinity mask In-Reply-To: <20160831163852.GB5598@localhost.localdomain> References: <1472468013-29936-1-git-send-email-hch@lst.de> <1472468013-29936-5-git-send-email-hch@lst.de> <20160831163852.GB5598@localhost.localdomain> Message-ID: <20160901084624.GC4115@lst.de> On Wed, Aug 31, 2016@12:38:53PM -0400, Keith Busch wrote: > This can't be right. We have a single affinity mask for the entire > set, but what I think we want is an one affinity mask for each > nr_io_queues. The irq_create_affinity_mask should then create an array > of cpumasks based on nr_vecs.. Nah, this is Thomas' creating abuse of the cpumask type. Every bit set in the affinity_mask means this is a cpu we allocate a vector / queue to.