From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfT23-0007Dt-AO for qemu-devel@nongnu.org; Thu, 01 Sep 2016 10:32:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfT1y-0001Nj-9o for qemu-devel@nongnu.org; Thu, 01 Sep 2016 10:31:54 -0400 Date: Thu, 1 Sep 2016 16:31:37 +0200 From: Kevin Wolf Message-ID: <20160901143137.GC6355@noname.redhat.com> References: <20160829171021.4902-1-pbutsykin@virtuozzo.com> <20160829171021.4902-2-pbutsykin@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160829171021.4902-2-pbutsykin@virtuozzo.com> Subject: Re: [Qemu-devel] [PATCH RFC v2 01/22] block/pcache: empty pcache driver filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Butsykin Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, den@openvz.org, jsnow@redhat.com, eblake@redhat.com, famz@redhat.com Am 29.08.2016 um 19:10 hat Pavel Butsykin geschrieben: > The basic version of pcache driver for easy preparation of a patch set. > > Signed-off-by: Pavel Butsykin > + .bdrv_aio_readv = pcache_aio_readv, > + .bdrv_aio_writev = pcache_aio_writev, Can you please use .bdrv_co_preadv/pwritev instead and make everything based on bytes rather than sectors? Internally you can still spawn AIO requests to achieve the same parallelism as you have now (we'll just need new byte-based bdrv_co_aio_prw_vector() wrappers, but the functionality is there) and I don't think making the outer layer coroutine based would be too hard. In fact it might even simplify some code. Kevin