All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sabitha George <sabitha.george@gmail.com>
Cc: wsa@the-dreams.de, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c
Date: Thu, 1 Sep 2016 20:19:53 +0200	[thread overview]
Message-ID: <20160901181953.GA6787@kroah.com> (raw)
In-Reply-To: <1472752095-18559-1-git-send-email-sabitha.george@gmail.com>

On Thu, Sep 01, 2016 at 11:18:15PM +0530, Sabitha George wrote:
> This is a patch to the ks7010_sdio.c that fixes the following
> warnings found by checkpatch.pl
> 1) Missing a blank line after declarations
> 2) braces are not necessary for single statement blocks
> 3) kfree(NULL) is safe and this check is probably not required
> 4) void function return statements are not generally useful
> 5) "foo * bar" should be "foo *bar"
> 6) Code indent should use tabs where possible
> 7) printk() should include KERN_ facility level

That's 7 different things, so this should be at least 7 different
patches :)

Please break this up and submit it as a patch series so it can be easily
reviewed and applied.

thanks,

greg k-h

      reply	other threads:[~2016-09-01 21:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-01 17:48 [PATCH] staging: ks7010: fix coding style issues in ks7010_sdio.c Sabitha George
2016-09-01 18:19 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160901181953.GA6787@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sabitha.george@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.