From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Arve Hj?nnev?g <arve@android.com>,
Michael Ryleev <gmar@google.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Christoph Hellwig <hch@lst.de>,
Yaniv Gardi <ygardi@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v5 5/8] char: rpmb: add RPMB simulation device
Date: Thu, 1 Sep 2016 22:45:47 +0200 [thread overview]
Message-ID: <20160901204547.GA5960@kroah.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542C5B98@hasmsx108.ger.corp.intel.com>
On Thu, Sep 01, 2016 at 08:25:28PM +0000, Winkler, Tomas wrote:
> > On Mon, Jul 18, 2016 at 11:27:50PM +0300, Tomas Winkler wrote:
> > > This is a simple platform device used for testing the RPMB subsystem.
> > > +static struct platform_device *rpmb_sim_pdev;
> >
> > A platform device? Ick, no please don't abuse that interface for this type of
> > thing. Make it a real device if you have one, and put it in the proper place. If
> > it's a "virtual" device, great, use that. But don't make something up like this
> > please.
>
> This is a virtual device (simulation), nothing behind it just a chunk of memory.
> Is this there any information missing to make it clearer?
Don't make it a platform device, make it a "virtual" device, don't abuse
the platform device/driver interface for something that isn't really a
platform device.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-01 20:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 20:27 [PATCH v5 0/8] Replay Protected Memory Block (RPMB) subsystem Tomas Winkler
2016-07-18 20:27 ` [PATCH v5 1/8] rpmb: add " Tomas Winkler
2016-07-18 20:27 ` [PATCH v5 2/8] char: rpmb: add sysfs-class ABI documentation Tomas Winkler
2016-08-31 10:53 ` Greg Kroah-Hartman
2016-07-18 20:27 ` [PATCH v5 3/8] char: rpmb: add device attributes Tomas Winkler
2016-08-31 10:56 ` Greg Kroah-Hartman
2016-09-01 20:21 ` Winkler, Tomas
2016-07-18 20:27 ` [PATCH v5 4/8] char: rpmb: provide a user space interface Tomas Winkler
2016-07-18 22:15 ` Paul Gortmaker
2016-07-20 9:02 ` Winkler, Tomas
2016-07-20 14:21 ` Paul Gortmaker
2016-08-05 20:08 ` Pavel Machek
2016-08-07 9:44 ` Winkler, Tomas
2016-08-31 10:49 ` Greg Kroah-Hartman
2016-09-01 20:05 ` Winkler, Tomas
2016-09-01 20:46 ` Greg Kroah-Hartman
2016-09-04 11:35 ` Winkler, Tomas
2016-09-04 20:20 ` Pavel Machek
2016-09-04 20:56 ` Winkler, Tomas
2016-07-18 20:27 ` [PATCH v5 5/8] char: rpmb: add RPMB simulation device Tomas Winkler
2016-08-31 10:57 ` Greg Kroah-Hartman
2016-08-31 10:58 ` Greg Kroah-Hartman
2016-09-01 20:25 ` Winkler, Tomas
2016-09-01 20:45 ` Greg Kroah-Hartman [this message]
2016-07-18 20:27 ` [PATCH v5 6/8] tools rpmb: add RPBM access tool Tomas Winkler
2016-07-18 20:27 ` [PATCH v5 7/8] mmc: block: register RPMB partition with the RPMB subsystem Tomas Winkler
2016-07-18 20:27 ` [PATCH v5 8/8] scsi: ufs: connect to " Tomas Winkler
2016-07-23 7:44 ` [PATCH v5 0/8] Replay Protected Memory Block (RPMB) subsystem Winkler, Tomas
2016-08-05 20:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901204547.GA5960@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Joao.Pinto@synopsys.com \
--cc=adrian.hunter@intel.com \
--cc=arve@android.com \
--cc=gmar@google.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tomas.winkler@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.