From: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v1] IB/ipoib: Report SG feature regardless of HW UD CSUM capability
Date: Thu, 1 Sep 2016 21:10:22 -0400 [thread overview]
Message-ID: <20160902011021.GB23742@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <20160719201113.GC28288-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Tue, Jul 19, 2016 at 02:11:13PM -0600, Jason Gunthorpe wrote:
> On Tue, Jul 19, 2016 at 11:02:32PM +0300, Yuval Shaia wrote:
>
> > ok, i see the point but as Leon Romanovsky mentioned - this is not an issue
> > with the patch itself, right? i.e. the original code relays on the fact
> > that HW supports UD-CSUM and did not checked QP's sg limit (we even do not
> > have any QP at this stage yet).
>
> ud-csum was only supported by one IB vendor and that vendor supports
> SG.
>
> You are changing things to enable SG on hardware that has never had SG
> enabled, so you need to make sure it works right..
My thoughts exactly.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-02 1:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 7:40 [PATCH v1] IB/ipoib: Report SG feature regardless of HW UD CSUM capability Yuval Shaia
[not found] ` <1468827648-17275-1-git-send-email-yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-07-18 8:09 ` Leon Romanovsky
2016-07-18 17:19 ` Jason Gunthorpe
[not found] ` <20160718171921.GA3193-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-19 5:42 ` Leon Romanovsky
2016-07-19 12:55 ` Yuval Shaia
[not found] ` <20160719125556.GA14768-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-07-19 19:34 ` Jason Gunthorpe
[not found] ` <20160719193453.GA28288-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-07-19 20:02 ` Yuval Shaia
[not found] ` <20160719200231.GC6129-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-07-19 20:11 ` Jason Gunthorpe
[not found] ` <20160719201113.GC28288-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-02 1:10 ` ira.weiny [this message]
[not found] ` <20160902011021.GB23742-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-09-02 11:46 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902011021.GB23742@phlsvsds.ph.intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.