From: Louie Lu <louie.lu@hopebaytech.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net,
florian.c.schilhabel@googlemail.com, amitoj1606@gmail.com,
bhaktipriya96@gmail.com, punitvara@gmail.com,
laerdevstudios@gmail.com, shivanib134@gmail.com,
devel@driverdev.osuosl.org
Subject: [PATCH 3/3] staging: rtl8712: fixed comment style and space indent
Date: Fri, 2 Sep 2016 18:16:10 +0800 [thread overview]
Message-ID: <20160902101610.GA9040@gserv> (raw)
In-Reply-To: <cover.1472810639.git.louie.lu@hopebaytech.com>
fixed comment style and space indent report from checkpatch:
* WARNING: Statements should start on a tabstop
* WARNING: Block comments use * on subsequent lines
* WARNING: suspect code indent for conditional statements (16, 32)
Signed-off-by: Louie Lu <louie.lu@hopebaytech.com>
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 37 ++++++++++++++++-----------
1 file changed, 22 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
index e205adf..5c05f21 100644
--- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
+++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
@@ -422,7 +422,8 @@ static int wpa_set_encryption(struct net_device *dev, struct ieee_param *param,
(u8)_FAIL)
ret = -EOPNOTSUPP;
} else {
- /* don't update "psecuritypriv->PrivacyAlgrthm" and
+ /*
+ * don't update "psecuritypriv->PrivacyAlgrthm" and
* "psecuritypriv->PrivacyKeyIndex=keyid", but can
* r8712_set_key to fw/cam
*/
@@ -664,7 +665,7 @@ static int r8711_wx_set_freq(struct net_device *dev,
struct iw_freq *fwrq = &wrqu->freq;
int rc = 0;
-/* If setting by frequency, convert to a channel */
+ /* If setting by frequency, convert to a channel */
if ((fwrq->e == 1) &&
(fwrq->m >= (int) 2.412e8) &&
(fwrq->m <= (int) 2.487e8)) {
@@ -827,7 +828,8 @@ static int r871x_wx_set_pmkid(struct net_device *dev,
for (j = 0; j < NUM_PMKID_CACHE; j++) {
if (!memcmp(psecuritypriv->PMKIDList[j].Bssid,
strIssueBssid, ETH_ALEN)) {
- /* BSSID is matched, the same AP => Remove
+ /*
+ *BSSID is matched, the same AP => Remove
* this PMKID information and reset it.
*/
eth_zero_addr(psecuritypriv->PMKIDList[j].Bssid);
@@ -870,11 +872,13 @@ static int r8711_wx_get_range(struct net_device *dev,
wrqu->data.length = sizeof(*range);
memset(range, 0, sizeof(*range));
- /* Let's try to keep this struct in the same order as in
+ /*
+ * Let's try to keep this struct in the same order as in
* linux/include/wireless.h
*/
- /* TODO: See what values we can set, and remove the ones we can't
+ /*
+ * TODO: See what values we can set, and remove the ones we can't
* set, or fill them with some default data.
*/
/* ~5 Mb/s real (802.11b) */
@@ -1714,7 +1718,8 @@ static int r871x_wx_set_auth(struct net_device *dev,
}
break;
case IW_AUTH_DROP_UNENCRYPTED:
- /* HACK:
+ /*
+ * HACK:
*
* wpa_supplicant calls set_wpa_enabled when the driver
* is loaded and unloaded, regardless of if WPA is being
@@ -1727,12 +1732,13 @@ static int r871x_wx_set_auth(struct net_device *dev,
*/
if (padapter->securitypriv.ndisencryptstatus ==
Ndis802_11Encryption1Enabled) {
- /* it means init value, or using wep,
- * ndisencryptstatus =
- * Ndis802_11Encryption1Enabled,
- * then it needn't reset it;
- */
- break;
+ /*
+ * it means init value, or using wep,
+ * ndisencryptstatus =
+ * Ndis802_11Encryption1Enabled,
+ * then it needn't reset it;
+ */
+ break;
}
if (paramval) {
@@ -1976,9 +1982,9 @@ static int r871x_get_ap_info(struct net_device *dev,
if (pdata->length >= 32) {
if (copy_from_user(data, pdata->pointer, 32))
return -EINVAL;
- data[32] = 0;
+ data[32] = 0;
} else {
- return -EINVAL;
+ return -EINVAL;
}
spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL);
phead = &queue->queue;
@@ -2107,7 +2113,8 @@ static int wpa_set_param(struct net_device *dev, u8 name, u32 value)
case IEEE_PARAM_TKIP_COUNTERMEASURES:
break;
case IEEE_PARAM_DROP_UNENCRYPTED:
- /* HACK:
+ /*
+ * HACK:
*
* wpa_supplicant calls set_wpa_enabled when the driver
* is loaded and unloaded, regardless of if WPA is being
--
2.8.2
next prev parent reply other threads:[~2016-09-02 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1472810639.git.louie.lu@hopebaytech.com>
2016-09-02 10:15 ` [PATCH 1/3] staging: rtl8712: delete one space before if statement Louie Lu
2016-09-02 10:15 ` [PATCH 2/3] staging: rtl8172: fixed comment style in rts871x_cmd.c Louie Lu
2016-09-02 10:16 ` Louie Lu [this message]
2016-09-02 12:55 ` [PATCH 3/3] staging: rtl8712: fixed comment style and space indent Greg KH
2016-09-02 13:04 ` Louie Lu
2016-09-02 13:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902101610.GA9040@gserv \
--to=louie.lu@hopebaytech.com \
--cc=Larry.Finger@lwfinger.net \
--cc=amitoj1606@gmail.com \
--cc=bhaktipriya96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=laerdevstudios@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=punitvara@gmail.com \
--cc=shivanib134@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.