From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfiQs-0000pb-9g for qemu-devel@nongnu.org; Fri, 02 Sep 2016 02:58:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfiQm-0007Lf-Cb for qemu-devel@nongnu.org; Fri, 02 Sep 2016 02:58:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfiQm-0007La-45 for qemu-devel@nongnu.org; Fri, 02 Sep 2016 02:58:28 -0400 Date: Fri, 2 Sep 2016 17:00:28 +1000 From: David Gibson Message-ID: <20160902170028.48a01768@voom.fritz.box> In-Reply-To: <20160902061847.GC18496@pxdev.xzpeter.org> References: <1472526419-5900-11-git-send-email-jasowang@redhat.com> <20160829213702.536df0df@t450s.home> <76fb2f05-4f9c-3e91-d301-3e0a6d4cabaf@redhat.com> <20160901022929.GA3558@pxdev.xzpeter.org> <20160831204342.77fbe728@t450s.home> <20160901035848.GC3558@pxdev.xzpeter.org> <20160902141504.05950823@voom.fritz.box> <20160902053733.GB10595@pxdev.xzpeter.org> <20160902161014.7e53530b@voom.fritz.box> <20160902061557.GB18496@pxdev.xzpeter.org> <20160902061847.GC18496@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/FcyFO=avEdRUsbXa+dGbtNe"; protocol="application/pgp-signature" Subject: Re: [Qemu-devel] [PATCH for 2.8 10/11] Revert "intel_iommu: Throw hw_error on notify_started" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: Alex Williamson , Jason Wang , mst@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, cornelia.huck@de.ibm.com, wexu@redhat.com, vkaplans@redhat.com --Sig_/FcyFO=avEdRUsbXa+dGbtNe Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 2 Sep 2016 14:18:47 +0800 Peter Xu wrote: > On Fri, Sep 02, 2016 at 02:15:57PM +0800, Peter Xu wrote: > > > No, implement the full notifier, and a listener which only wants the > > > invalidates can just ignore callbacks which add new mappings. > > >=20 > > > As I said, you'll need this to get VFIO working with vIOMMU which > > > someone is bound to want soon enough anyway. =20 > >=20 > > But for vhost cases, we do not need CM bit enabled. That might be the > > difference? > >=20 > > I think we need to have vhost working even without CM bit. Device > > IOTLB should be able to achieve that. =20 >=20 > The problem is that, IMHO we should be very careful on enabling CM > bit. After enabling it, system might get slower (though I haven't > tried it yet), or even very slow? So maybe we will only enable it when > really needed (e.g., to do device passthrough and build the shadow > table). Um.. what's the CM bit and what does it have to do with anything? --=20 David Gibson Senior Software Engineer, Virtualization, Red Hat --Sig_/FcyFO=avEdRUsbXa+dGbtNe Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXySOMAAoJEGw4ysog2bOS6REP/ir0IOKWA9oNfD4VF86y/n/P otC+y4NA5GTTvs39M4Hb9oY+GT2rCmYozycNaHTEOZcz36wpNcDUddhSjpqvr30o S+0p8Fwi8x0Kvk9Ss9ICNWtu+J8SKqTaSXwR8Lh1N/5pOSaUk/JivXp4TOcrY+WC EK4bgG29nyMHUKSv0mp+oTcrFNrmLzSxCqVzyEB+5vcelCGI9M30oJjvhncpIGz7 uLB0xVKvBzC9/yEEb7Dn0tnRkgsme1LVy3fHMeGluWf3qvtvjG1LjWr/0H23VftF Fl3+L8bkaoOb2g/t4JNbZ0vQVuJxe9JFV/JYzLP8Thl8LZYw06dwa7MXEmz7h8LX dmOTIjJZjWHh6QwxlySrNYl19qZYIJ4dL/Nhow2HJaXwlRn9iCBnA760g/aNozSn FZ3gWFadya+8J/21XIH2Ea8Zq6fGwHq3lpeBgNtGYF2aBoE0WBNT82/3xKBhlYnV iojvC1LI6yNBvDbcLwoi1dIb+XojLaaXNsVId9gXuammmi9vWfBMovY2RNdSsQRL vn0IvgI4z885kcstOk967kYw84x8OUrSCtPnZa6CwmVtOZtuSrVhIBVs/vjWPA6z Od3M9lgTMsGh/0icd1QeRK0SOtVvkXDNyoSNsLmq7aOGm37q968wNySAexF7Lsod bZqL8T1gEmxolaNSV4F/ =fBVj -----END PGP SIGNATURE----- --Sig_/FcyFO=avEdRUsbXa+dGbtNe--