From: Greg KH <gregkh@linuxfoundation.org>
To: Amit Ghadge <amitg.b14@gmail.com>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.
Date: Sun, 4 Sep 2016 10:35:37 +0200 [thread overview]
Message-ID: <20160904083537.GA18355@kroah.com> (raw)
In-Reply-To: <1472933463-5290-2-git-send-email-amitg.b14@gmail.com>
On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote:
> Fixes checkpatch warning:
> WARNING: Block comments use * on subsequent lines
>
> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid
> of checkpatch.pl "CHECK" output "Prefer using the BIT macro".
> Replace Avoid CamelCase range_0_20mA to range_0_20ma.
That's multiple things in the same patch, and you didn't even test build
your change :(
Please do better than this in the future.
greg k-h
next prev parent reply other threads:[~2016-09-04 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 20:11 [PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines Amit Ghadge
2016-09-03 20:11 ` [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check Amit Ghadge
2016-09-03 20:42 ` kbuild test robot
2016-09-04 8:35 ` Greg KH [this message]
2016-09-04 10:15 ` Amit Ghadge
2016-09-05 13:11 ` Ian Abbott
2016-09-05 13:32 ` Ian Abbott
2016-09-05 14:12 ` Amit Ghadge
2016-09-05 13:15 ` [PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines Ian Abbott
2016-09-05 14:13 ` Amit Ghadge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160904083537.GA18355@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=amitg.b14@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.