From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH rdma-next V3 4/6] RDMA/core: Move HFI1 IOCTL declarations to common file
Date: Sun, 4 Sep 2016 20:41:58 -0600 [thread overview]
Message-ID: <20160905024158.GE21542@obsidianresearch.com> (raw)
In-Reply-To: <1472988635-31463-5-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Sun, Sep 04, 2016 at 02:30:33PM +0300, Leon Romanovsky wrote:
> +/* User commands. */
> +#define HFI1_CMD_ASSIGN_CTXT 1 /* allocate HFI and context */
> +#define HFI1_IOCTL_ASSIGN_CTXT \
> + _IOWR(IB_IOCTL_MAGIC, __NUM(ASSIGN_CTXT), struct hfi1_user_info)
I still vote for dropping the HFI1_CMD_ASSIGN_CTXT defines. Inlining
the number is far more readable than that ugly __NUM macro.
If it was done consistently you might have an arugment, but just doing
it in one place with no purpose is silly.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-05 2:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-04 11:30 [PATCH rdma-next V3 0/6] Refactor RDMA IOCTL declarations Leon Romanovsky
[not found] ` <1472988635-31463-1-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-04 11:30 ` [PATCH rdma-next V3 1/6] RDMA/core: Commonize RDMA IOCTL declarations location Leon Romanovsky
2016-09-04 11:30 ` [PATCH rdma-next V3 2/6] RDMA/core: Move legacy MAD IOCTL declarations to common file Leon Romanovsky
2016-09-04 11:30 ` [PATCH rdma-next V3 3/6] RDMA/hfi1: Avoid redeclaration error Leon Romanovsky
2016-09-04 11:30 ` [PATCH rdma-next V3 4/6] RDMA/core: Move HFI1 IOCTL declarations to common file Leon Romanovsky
[not found] ` <1472988635-31463-5-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-05 2:41 ` Jason Gunthorpe [this message]
[not found] ` <20160905024158.GE21542-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-05 5:31 ` Leon Romanovsky
2016-09-04 11:30 ` [PATCH rdma-next V3 5/6] RDMA/core: Rename RDMA magic number Leon Romanovsky
2016-09-04 11:30 ` [PATCH rdma-next V3 6/6] RDMA/core: Unify style of IOCTL commands Leon Romanovsky
[not found] ` <1472988635-31463-7-git-send-email-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-05 2:42 ` Jason Gunthorpe
2016-09-05 5:33 ` Leon Romanovsky
[not found] ` <20160905053342.GW21847-2ukJVAZIZ/Y@public.gmane.org>
2016-09-23 17:31 ` Doug Ledford
2016-09-06 13:00 ` Dalessandro, Dennis
[not found] ` <1473166808.2465.9.camel-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-09-07 7:01 ` Leon Romanovsky
[not found] ` <20160907070109.GC3639-2ukJVAZIZ/Y@public.gmane.org>
2016-09-23 17:32 ` Doug Ledford
2016-09-23 17:34 ` [PATCH rdma-next V3 0/6] Refactor RDMA IOCTL declarations Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905024158.GE21542@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.