From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] virtio: xstats name issue
Date: Mon, 5 Sep 2016 14:19:28 +0800 [thread overview]
Message-ID: <20160905061928.GA4243@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20160905043329.GJ30752@yliu-dev.sh.intel.com>
On Mon, Sep 05, 2016 at 12:33:29PM +0800, Yuanhan Liu wrote:
> Few generic (trivial) comments first:
>
> - cc to related maintainers
>
> - follow the right prefix, "net/virtio" but not "virtio"
>
> - start commit summary with a verb, and start with "fix" for bug fixing patch.
I forgot to mention that you need to add a fixline for bug fix patch.
--yliu
next prev parent reply other threads:[~2016-09-05 6:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 8:01 [PATCH] virtio: xstats name issue Zhiyong Yang
2016-09-05 4:33 ` Yuanhan Liu
2016-09-05 5:35 ` Yang, Zhiyong
2016-09-05 6:19 ` Yuanhan Liu [this message]
2016-09-06 7:50 ` [PATCH v2] net/virtio: fix " Zhiyong Yang
2016-09-06 12:27 ` Yuanhan Liu
2016-09-07 1:32 ` Yang, Zhiyong
2016-09-07 6:11 ` [PATCH v3] " Zhiyong Yang
2016-09-07 7:22 ` [dpdk-stable] " Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905061928.GA4243@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.