Re: [PATCH] tools/firmware: Rename bios.bin to seabios.bin

[Wei Liu <wei.liu2@citrix.com>]

On Mon, Sep 05, 2016 at 10:28:25AM +0100, Andrew Cooper wrote:
> On 05/09/16 09:09, Anthony PERARD wrote:
> > On Mon, Aug 22, 2016 at 11:24:05AM +0100, Wei Liu wrote:
> >> On Fri, Aug 19, 2016 at 03:26:23PM +0100, Andrew Cooper wrote:
> >>> bios.bin as a name is far too generic.  Rename it to seabios.bin.
> >>>
> >>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> >> Hmm... I remember the first few versions of that series had it named
> >> seabios.bin and I acked that.
> >>
> >> Anyway, I think I will give Anthony a chance to clarify why he changed
> >> the name.
> > I've changed it because someone ask for it:
> > https://lists.xenproject.org/archives/html/xen-devel/2016-03/msg02371.html
> 
> It was admittedly lacking a question mark, but that was a question not a
> statement.
> 
> The answer is "because there are a load of other bios binaries stored in
> the same directory".
> 
> > It was to match how seabios is installed by default.
> 
> This is not relevant.  The version of seabios built by Xen should fit
> into the Xen expectations.  If this means renaming it to make it clear
> which bios it it, then so be it.

I think renaming it to seabios.bin is better.

Acked-by: Wei Liu <wei.liu2@citrix.com>

Wei.

> 
> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel