From: Thierry Reding <thierry.reding@gmail.com>
To: Olliver Schinagl <oliver@schinagl.nl>
Cc: Ariel D'Alessandro <ariel@vanguardiasur.com>,
Joachim Eastwood <manabian@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data
Date: Mon, 5 Sep 2016 12:15:09 +0200 [thread overview]
Message-ID: <20160905101509.GE31424@ulmo.ba.sec> (raw)
In-Reply-To: <1472143629-29890-1-git-send-email-oliver@schinagl.nl>
[-- Attachment #1: Type: text/plain, Size: 874 bytes --]
On Thu, Aug 25, 2016 at 06:47:09PM +0200, Olliver Schinagl wrote:
> The lpc18xx driver currently manipulates the pwm_device struct directly
> rather then using the pwm_set_chip_data. While the current method may
> save a clock cycle or two, it is more obvious that data is set to
> the local chip data pointer.
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
> Hi,
>
> This is a resend of a patch-series I sent last year. There was no technical
> related feedback and so I am re-sending the patch as is. I did rebase it to
> Linus's current master.
>
> Changes since v1:
> - removed wrongfully added sun4i patch
> - split patch series into a single patch
> - added author
>
> drivers/pwm/pwm-lpc18xx-sct.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Applied with minor bikeshedding.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data
Date: Mon, 5 Sep 2016 12:15:09 +0200 [thread overview]
Message-ID: <20160905101509.GE31424@ulmo.ba.sec> (raw)
In-Reply-To: <1472143629-29890-1-git-send-email-oliver@schinagl.nl>
On Thu, Aug 25, 2016 at 06:47:09PM +0200, Olliver Schinagl wrote:
> The lpc18xx driver currently manipulates the pwm_device struct directly
> rather then using the pwm_set_chip_data. While the current method may
> save a clock cycle or two, it is more obvious that data is set to
> the local chip data pointer.
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
> Hi,
>
> This is a resend of a patch-series I sent last year. There was no technical
> related feedback and so I am re-sending the patch as is. I did rebase it to
> Linus's current master.
>
> Changes since v1:
> - removed wrongfully added sun4i patch
> - split patch series into a single patch
> - added author
>
> drivers/pwm/pwm-lpc18xx-sct.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Applied with minor bikeshedding.
Thanks,
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160905/e6185af0/attachment.sig>
next prev parent reply other threads:[~2016-09-05 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 16:47 [PATCHv2] pwm: lpc-18xx: use pwm_set_chip_data Olliver Schinagl
2016-08-25 16:47 ` Olliver Schinagl
2016-08-25 16:47 ` Olliver Schinagl
2016-09-02 16:07 ` Ariel D'Alessandro
2016-09-02 16:07 ` Ariel D'Alessandro
2016-09-05 10:15 ` Thierry Reding [this message]
2016-09-05 10:15 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905101509.GE31424@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=ariel@vanguardiasur.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=oliver@schinagl.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.