From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgv6r-0001lV-Nf for qemu-devel@nongnu.org; Mon, 05 Sep 2016 10:42:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgv6n-0005AT-IO for qemu-devel@nongnu.org; Mon, 05 Sep 2016 10:42:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgv6n-0005AP-D2 for qemu-devel@nongnu.org; Mon, 05 Sep 2016 10:42:49 -0400 Date: Mon, 5 Sep 2016 15:42:45 +0100 From: "Daniel P. Berrange" Message-ID: <20160905144245.GH24656@redhat.com> Reply-To: "Daniel P. Berrange" References: <1473078979-149076-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1473078979-149076-1-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v3] crypto: fix building complaint List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: qemu-devel@nongnu.org On Mon, Sep 05, 2016 at 08:36:19PM +0800, Gonglei wrote: > gnutls commit 846753877d renamed LIBGNUTLS_VERSION_NUMBER to GNUTLS_VERSION_NUMBER. > If using gnutls before that verion, we'll get the below warning: > crypto/tlscredsx509.c:618:5: warning: "GNUTLS_VERSION_NUMBER" is not defined > > Because gnutls 3.x still defines LIBGNUTLS_VERSION_NUMBER for back compat, Let's > use LIBGNUTLS_VERSION_NUMBER instead of GNUTLS_VERSION_NUMBER to fix building > complaint. > > Signed-off-by: Gonglei > --- > v3: use LIBGNUTLS_VERSION_NUMBER instead of GNUTLS_VERSION_NUMBER. [Daniel] > > crypto/init.c | 3 +-- > crypto/tlscredsx509.c | 6 +++--- > tests/crypto-tls-x509-helpers.h | 1 - > 3 files changed, 4 insertions(+), 6 deletions(-) Thanks, queued in my crypto branch Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|