From: Thierry Reding <thierry.reding@gmail.com>
To: David Hsu <davidhsu@google.com>
Cc: gregkh@linuxfoundation.org, sspatil@google.com,
linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: Unexport children before chip removal
Date: Mon, 5 Sep 2016 16:46:41 +0200 [thread overview]
Message-ID: <20160905144641.GR31424@ulmo.ba.sec> (raw)
In-Reply-To: <1470779866-74776-1-git-send-email-davidhsu@google.com>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Tue, Aug 09, 2016 at 02:57:46PM -0700, David Hsu wrote:
> Exported pwm channels aren't removed before the pwmchip and are
> leaked. This results in invalid sysfs files. This fix removes
> all exported pwm channels before chip removal.
>
> Signed-off-by: David Hsu <davidhsu@google.com>
> ---
> drivers/pwm/core.c | 2 ++
> drivers/pwm/sysfs.c | 18 ++++++++++++++++++
> include/linux/pwm.h | 5 +++++
> 3 files changed, 25 insertions(+)
I've applied this with the following added to the commit message:
Fixes: 76abbdde2d95 ("pwm: Add sysfs interface")
since this seems to have been wrong since forever.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-09-05 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 21:57 [PATCH] pwm: Unexport children before chip removal David Hsu
2016-08-10 8:49 ` Greg KH
2016-08-10 22:54 ` David Hsu
2016-09-05 14:46 ` Thierry Reding [this message]
2016-09-05 15:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905144641.GR31424@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=davidhsu@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sspatil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.