From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgy8E-0006J9-Bn for qemu-devel@nongnu.org; Mon, 05 Sep 2016 13:56:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgy89-0004y2-L8 for qemu-devel@nongnu.org; Mon, 05 Sep 2016 13:56:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgy89-0004xv-Cq for qemu-devel@nongnu.org; Mon, 05 Sep 2016 13:56:25 -0400 Date: Mon, 5 Sep 2016 18:56:20 +0100 From: "Daniel P. Berrange" Message-ID: <20160905175619.GO24656@redhat.com> Reply-To: "Daniel P. Berrange" References: <1473097811-13519-1-git-send-email-ashijeetacharya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1473097811-13519-1-git-send-email-ashijeetacharya@gmail.com> Subject: Re: [Qemu-devel] [PATCH] Move max-bandwidth and downtime-limit into migrate_set_parameter for both hmp and qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: lcapitulino@redhat.com, quintela@redhat.com, amit.shah@redhat.com, eblake@redhat.com, armbru@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org On Mon, Sep 05, 2016 at 11:20:11PM +0530, Ashijeet Acharya wrote: > Mark old-commands for speed and downtime as deprecated. > Move max-bandwidth and downtime-limit into migrate-set-parameters for > setting maximum migration speed and expected downtime limit parameters > respectively. > Change downtime units to milliseconds and update the query part in both > hmp and qmp qemu control interfaces. > > Signed-off-by: Ashijeet Acharya > --- > hmp-commands.hx | 8 +-- > hmp.c | 29 +++++++++- > include/migration/migration.h | 1 - > migration/migration.c | 122 +++++++++++++++++++++++++++++++----------- > qapi-schema.json | 37 ++++++++++--- > qmp-commands.hx | 21 +++++--- > 6 files changed, 169 insertions(+), 49 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 848efee..c7f1ef9 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -980,16 +980,16 @@ ETEXI > > { > .name = "migrate_set_downtime", > - .args_type = "value:T", > + .args_type = "value:i", > .params = "value", > - .help = "set maximum tolerated downtime (in seconds) for migrations", > + .help = "set maximum tolerated downtime (in milliseconds) for migrations", > .mhandler.cmd = hmp_migrate_set_downtime, > }, > > STEXI > -@item migrate_set_downtime @var{second} > +@item migrate_set_downtime @var{milliseconds} > @findex migrate_set_downtime > -Set maximum tolerated downtime (in seconds) for migration. > +Set maximum tolerated downtime (in milliseconds) for migration. > ETEXI Sorry, you misunderstood - while we should use 'milliseconds' for downtime in the 'migrate_set_parameters' command, we cannot change the existing 'migrate_set_downtime' command. Changing that would break compatibility with existing apps. > diff --git a/qapi-schema.json b/qapi-schema.json > index 5658723..66ed582 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -637,12 +637,19 @@ > # hostname must be provided so that the server's x509 > # certificate identity can be validated. (Since 2.7) > # > +# @max-bandwidth: to set maximum speed for migration. maximum speed in > +# bytes. (Since 2.8) s/bytes/bytes per second/ (and elsewhere in this patch) > +# > +# @downtime-limit: set maximum tolerated downtime for migration. maximum downtime > +# in milliseconds (Since 2.8) > +# Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|