Re: [OSSTEST PATCH 0/7] Apropos of XTF: Improve failed step selection

[Wei Liu <wei.liu2@citrix.com>]

On 
> On Thu, Aug 11, 2016 at 05:17:56PM +0100, Ian Jackson wrote:
> > Running XTF in osstest is likely to produce failures where multiple
> > steps fail interestingly.  We would like to prefer to report, and
> > bisect, earlier steps.
> > 
> > This series does that.
> > 
> > Wei, NB, this has a conflict with the XTF pre series that you have
> > taken over.  The conflict is not trivial, but easy.  The conflicting
> > patch is:
> >   Executive: Previous duration estimator: use overall time, not sum of steps
> > 
> 
> The rebased patch is as followed, please check.
> 
> ---8<---
> From bbdc727965b4d4280bac670823f013d078a54b93 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@eu.citrix.com>
> Date: Fri, 8 Jul 2016 19:30:58 +0100
> Subject: [OSSTEST PATCH] Executive: Previous duration estimator: use overall
>  time, not sum of steps
> Cc: ian.jackson@eu.citrix.com
> 
> Some jobs runs steps in parallel.  Do not add up all the insividual
> step durations.  Instead, calculate the duration as the time between
> first step start and last step finish.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> [ wei: rebase and fix conflict ]
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  Osstest/Executive.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
> index 7e31b35..2187a73 100644
> --- a/Osstest/Executive.pm
> +++ b/Osstest/Executive.pm
> @@ -1068,7 +1068,7 @@ END
>                FROM steps
>               WHERE flight=? AND job=?
>          )
> -            SELECT sum(finished-started)
> +            SELECT sum(max(finished)-min(started))
>                  AS duration
>                FROM tsteps
>               WHERE step != 'ts-hosts-allocate'
> -- 
> 2.1.4
> 


Hmm... there seems to be a problem with this patch.

http://osstest.xs.citrite.net/~osstest/testlogs/logs/67641/build-amd64-xtf/2.ts-hosts-allocate.log

2016-09-05 17:51:48 Z allocating hosts: host 
DBD::Pg::st execute failed: ERROR:  aggregate function calls cannot be nested
LINE 7:             SELECT sum(max(finished)-min(started))
                               ^ [for Statement "        WITH tsteps AS 
        (
            SELECT *
              FROM steps
             WHERE flight=? AND job=?
        )
            SELECT sum(max(finished)-min(started))
                AS duration
              FROM tsteps
             WHERE step != 'ts-hosts-allocate'
" with ParamValues: 1='67640', 2='build-amd64-xtf'] at Osstest/Executive.pm line 1127, <GEN4> line 10.
resourcecall DBD::Pg::st execute failed: ERROR:  aggregate function calls cannot be nested
LINE 7:             SELECT sum(max(finished)-min(started))
                               ^ [for Statement "        WITH tsteps AS 
        (
            SELECT *
              FROM steps
             WHERE flight=? AND job=?
        )
            SELECT sum(max(finished)-min(started))
                AS duration
              FROM tsteps
             WHERE step != 'ts-hosts-allocate'
" with ParamValues: 1='67640', 2='build-amd64-xtf'] at Osstest/Executive.pm line 1127, <GEN4> line 10.
Died at Osstest/Executive.pm line 903, <GEN4> line 10.
+ rc=255
+ date -u +%Y-%m-%d %H:%M:%S Z exit status 255
2016-09-05 17:51:49 Z exit status 255
+ exit 255

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel