From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled
Date: Mon, 5 Sep 2016 22:05:40 +0200 [thread overview]
Message-ID: <20160905220540.633a3cd4@free-electrons.com> (raw)
In-Reply-To: <20160905145120.8613-1-bernd.kuhls@t-online.de>
Hello,
On Mon, 5 Sep 2016 16:51:19 +0200, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/c32/c32a21240a9933796ee850349a62ff3c2314f25c/
> http://autobuild.buildroot.net/results/22a/22a9769d83d2a398bb6b264d342b2077c41c9cc5/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/ffmpeg/ffmpeg.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
> index a90d437..74f783c 100644
> --- a/package/ffmpeg/ffmpeg.mk
> +++ b/package/ffmpeg/ffmpeg.mk
> @@ -250,7 +250,8 @@ endif
>
> # To avoid a circular dependency only use opencv if opencv itself does
> # not depend on ffmpeg.
> -ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG),yx)
> +# opencv2 is broken if BR2_ARM_ENABLE_VFP is enabled
> +ifeq ($(BR2_PACKAGE_OPENCV_LIB_IMGPROC)x$(BR2_PACKAGE_OPENCV_WITH_FFMPEG)x$(BR2_ARM_ENABLE_VFP),yxx)
I'm not really happy with this fix. When you're using OpenCV/FFmpeg on
ARM, you definitely want to be able to use the VFP. So I'd prefer to
see the problem fixed rather than having this combination disabled.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-05 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 14:51 [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Bernd Kuhls
2016-09-05 14:51 ` [Buildroot] [PATCH 2/2] package/ffmpeg: add optional support for opencv3 Bernd Kuhls
2016-09-06 19:39 ` Thomas Petazzoni
2016-09-05 20:05 ` Thomas Petazzoni [this message]
2016-09-05 20:20 ` [Buildroot] [PATCH 1/2] package/ffmpeg: opencv2 support is broken if BR2_ARM_ENABLE_VFP is enabled Bernd Kuhls
2016-09-05 22:22 ` Arnout Vandecappelle
2016-09-05 22:32 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905220540.633a3cd4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.