From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhDUO-0008Mz-4K for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:20:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhDUJ-0001WX-Tp for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:20:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhDUJ-0001WT-Nw for qemu-devel@nongnu.org; Tue, 06 Sep 2016 06:20:19 -0400 Date: Tue, 6 Sep 2016 18:20:15 +0800 From: Peter Xu Message-ID: <20160906102015.GF21051@pxdev.xzpeter.org> References: <1471498092-27135-1-git-send-email-peterx@redhat.com> <1471498092-27135-3-git-send-email-peterx@redhat.com> <20160906095326.GB10525@al.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160906095326.GB10525@al.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/4] error-report: provide error_report_abort() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, armbru@redhat.com, peter.maydell@linaro.org, pbonzini@redhat.com On Tue, Sep 06, 2016 at 05:53:26PM +0800, Fam Zheng wrote: > On Thu, 08/18 13:28, Peter Xu wrote: > > A twin for error_report_fatal(), for programming errors. > > > > Signed-off-by: Peter Xu > > --- > > include/qemu/error-report.h | 1 + > > util/qemu-error.c | 12 ++++++++++++ > > 2 files changed, 13 insertions(+) > > > > diff --git a/include/qemu/error-report.h b/include/qemu/error-report.h > > index eb8260e..51a6f31 100644 > > --- a/include/qemu/error-report.h > > +++ b/include/qemu/error-report.h > > @@ -37,6 +37,7 @@ void error_set_progname(const char *argv0); > > void error_vreport(const char *fmt, va_list ap) GCC_FMT_ATTR(1, 0); > > void error_report(const char *fmt, ...) GCC_FMT_ATTR(1, 2); > > void error_report_fatal(const char *fmt, ...) GCC_FMT_ATTR(1, 2); > > +void error_report_abort(const char *fmt, ...) GCC_FMT_ATTR(1, 2); > > const char *error_get_progname(void); > > extern bool enable_timestamp_msg; > > > > diff --git a/util/qemu-error.c b/util/qemu-error.c > > index 81379e1..d1c6b10 100644 > > --- a/util/qemu-error.c > > +++ b/util/qemu-error.c > > @@ -11,6 +11,7 @@ > > */ > > > > #include > > +#include > > Not needed, again. Will remove above two lines. Thanks! -- peterx