From: Wei Liu <wei.liu2@citrix.com>
To: Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, julien.grall@arm.com,
tamas@tklengyel.com, jbeulich@suse.com
Subject: Re: [PATCH V3] tools/libxc, xen/x86: Added xc_set_mem_access_multi()
Date: Tue, 6 Sep 2016 11:32:16 +0100 [thread overview]
Message-ID: <20160906103216.GO18255@citrix.com> (raw)
In-Reply-To: <7f9892ad-2d9d-4e91-9632-5393a7e1cf67@bitdefender.com>
On Tue, Sep 06, 2016 at 01:27:21PM +0300, Razvan Cojocaru wrote:
> On 09/06/2016 01:16 PM, Ian Jackson wrote:
> > Razvan Cojocaru writes ("[PATCH V3] tools/libxc, xen/x86: Added xc_set_mem_access_multi()"):
> >> Currently it is only possible to set mem_access restrictions only for
> >> a contiguous range of GFNs (or, as a particular case, for a single GFN).
> >> This patch introduces a new libxc function taking an array of GFNs.
> >> The alternative would be to set each page in turn, using a userspace-HV
> >> roundtrip for each call, and triggering a TLB flush per page set.
> >>
> >> Signed-off-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
> >> Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> > I have no objection with my tools maintainer hat on. But I have a
> > question for you and/or the hypervisor maintainers:
> >
> > Could this aim be achieved with a multicall ? (Can multicalls defer
> > the TLB flush?)
>
> I assume your question is: could we do multiple xc_set_mem_access()
> calls and then call something like xc_tlb_flush() at the end of it,
> instead of a singke xc_set_mem_access_multi() call?
>
FWIW: I think you misunderstood, multicall is a Xen hypercall to batch
multiple hypercalls into one.
But as Jan said in the other reply, there is no multicall for HVM
guests (yet) -- see hvm/hvm.c:hvm_hypercall_table.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-06 10:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 10:00 [PATCH V3] tools/libxc, xen/x86: Added xc_set_mem_access_multi() Razvan Cojocaru
2016-09-06 10:16 ` Ian Jackson
2016-09-06 10:26 ` Jan Beulich
2016-09-06 10:33 ` [PATCH V3] tools/libxc, xen/x86: Added xc_set_mem_access_multi() [and 1 more messages] Ian Jackson
2016-09-06 10:35 ` [PATCH V3] tools/libxc, xen/x86: Added xc_set_mem_access_multi() Razvan Cojocaru
2016-09-06 10:27 ` Razvan Cojocaru
2016-09-06 10:32 ` Wei Liu [this message]
2016-09-06 10:40 ` George Dunlap
2016-09-06 10:39 ` Julien Grall
2016-09-06 10:45 ` Razvan Cojocaru
2016-09-06 10:51 ` Julien Grall
2016-09-06 11:05 ` George Dunlap
2016-09-06 11:20 ` Julien Grall
2016-09-06 11:34 ` George Dunlap
2016-09-06 11:51 ` Ian Jackson
2016-09-06 11:57 ` Julien Grall
2016-09-06 11:53 ` Julien Grall
2016-09-06 12:41 ` Razvan Cojocaru
2016-09-06 14:08 ` Ian Jackson
2016-09-06 14:27 ` Razvan Cojocaru
2016-09-06 11:36 ` Razvan Cojocaru
2016-09-06 11:48 ` Julien Grall
2016-09-06 11:06 ` Razvan Cojocaru
2016-09-06 14:07 ` Jan Beulich
2016-09-06 14:21 ` Razvan Cojocaru
2016-09-06 14:28 ` Jan Beulich
2016-09-07 8:36 ` Razvan Cojocaru
2016-09-07 8:45 ` Razvan Cojocaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906103216.GO18255@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=rcojocaru@bitdefender.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.