All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] add PACKAGECONFIG for lvm thin provisioning
Date: Tue, 6 Sep 2016 17:03:09 +0200	[thread overview]
Message-ID: <20160906150309.GA2645@jama> (raw)
In-Reply-To: <6f2b25d00c6cdfbafa49e5d5b3e2802279556200.1473153229.git.hongxu.jia@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 2327 bytes --]

On Tue, Sep 06, 2016 at 05:15:15AM -0400, Hongxu Jia wrote:
> The thin provisioning tools is runtime dependency,
> so disable build time detection.
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>

Next time start the summary with component name.

> ---
>  meta-oe/recipes-support/lvm2/lvm2.inc | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/lvm2/lvm2.inc b/meta-oe/recipes-support/lvm2/lvm2.inc
> index e2feeb3..d66daf8 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2.inc
> +++ b/meta-oe/recipes-support/lvm2/lvm2.inc
> @@ -18,10 +18,13 @@ S = "${WORKDIR}/LVM2.${PV}"
>  
>  inherit autotools-brokensep pkgconfig systemd
>  
> -PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)}"
> +PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
> +                   thin-provisioning-tools \
> +"
>  
>  PACKAGECONFIG[readline] = "--enable-readline,--disable-readline,readline"
>  PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux"
> +PACKAGECONFIG[thin-provisioning-tools] = "--with-thin=internal,--with-thin=none,,thin-provisioning-tools"
>  
>  # Unset user/group to unbreak install.
>  EXTRA_OECONF = "--with-user= \
> @@ -38,6 +41,11 @@ EXTRA_OECONF = "--with-user= \
>                  --with-udev-prefix= \
>                  --with-usrlibdir=${libdir} \
>                  --with-systemdsystemunitdir=${systemd_system_unitdir} \
> +                --disable-thin_check_needs_check \
> +                --with-thin-check=${sbindir}/thin_check \
> +                --with-thin-dump=${sbindir}/thin_dump \
> +                --with-thin-repair=${sbindir}/thin_repair \
> +                --with-thin-restore=${sbindir}/thin_restore \
>  "
>  
>  CACHED_CONFIGUREVARS += "MODPROBE_CMD=${base_sbindir}/modprobe"
> @@ -66,6 +74,6 @@ TARGET_CC_ARCH += "${LDFLAGS}"
>  FILES_${PN} += "${libdir}/device-mapper/*.so ${base_libdir}/udev"
>  FILES_${PN}-dbg += "${libdir}/device-mapper/.debug"
>  
> -RDEPENDS_${PN} = "bash thin-provisioning-tools"
> +RDEPENDS_${PN} = "bash"
>  
>  CONFFILES_${PN} += "${sysconfdir}/lvm/lvm.conf"
> -- 
> 2.8.1
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]

  reply	other threads:[~2016-09-06 15:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06  9:15 [meta-oe][PATCH 0/1] add PACKAGECONFIG for lvm thin provisioning Hongxu Jia
2016-09-06  9:15 ` [PATCH 1/1] " Hongxu Jia
2016-09-06 15:03   ` Martin Jansa [this message]
2016-09-06 15:51     ` [PATCH] lvm2: " Hongxu Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160906150309.GA2645@jama \
    --to=martin.jansa@gmail.com \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.