From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 01/20] livepatch: Bubble up sanity checks on Elf relocs Date: Tue, 6 Sep 2016 13:13:03 -0400 Message-ID: <20160906171303.GD2161@char.us.oracle.com> References: <1472132255-23470-1-git-send-email-konrad.wilk@oracle.com> <1472132255-23470-2-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bhJwA-0005kd-FZ for xen-devel@lists.xenproject.org; Tue, 06 Sep 2016 17:13:30 +0000 Content-Disposition: inline In-Reply-To: <1472132255-23470-2-git-send-email-konrad.wilk@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org, konrad@kernel.org, ross.lagerwall@citrix.com, sstabellini@kernel.org, julien.grall@arm.com Cc: Andrew Cooper List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBBdWcgMjUsIDIwMTYgYXQgMDk6Mzc6MTZBTSAtMDQwMCwgS29ucmFkIFJ6ZXN6dXRl ayBXaWxrIHdyb3RlOgo+IFRoZSBjaGVja3MgZm9yIFNIVF9SRUxbLEFdIEVMRiBzYW5pdHkgY2hl Y2tzIGRvZXMgbm90IG5lZWQgdG8KPiBiZSBpbiB0aGUgcGxhdGZvcm0gc3BlY2lmaWMgZmlsZSBh bmQgY2FuIGJlIGJ1YmJsZWQgdXAKPiBpbiB0aGUgcGxhdGZvcm0gYWdub3N0aWMgZmlsZS4KPiAK PiBUaGlzIG1ha2VzIHRoZSBBUk0gMzIvNjQgaW1wbGVtZW50YXRpb24gZWFzaWVyIGFzIHRoZQo+ IGR1cGxpY2F0ZSBjaGVja3MgZG9uJ3QgaGF2ZSB0byBiZSBpbiB0aGUgcGxhdGZvcm0gc3BlY2lm aWMgZmlsZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25y YWQud2lsa0BvcmFjbGUuY29tPgo+IAo+IC0tLQo+IENjOiBLb25yYWQgUnplc3p1dGVrIFdpbGsg PGtvbnJhZC53aWxrQG9yYWNsZS5jb20+Cj4gQ2M6IFJvc3MgTGFnZXJ3YWxsIDxyb3NzLmxhZ2Vy d2FsbEBjaXRyaXguY29tPgoKUm9zcywgY291bGQgeW91IHJldmlldyB0aGUgcGF0Y2ggcGxlYXNl PwoKCj4gQ2M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4gCj4g djE6IEZpcnN0IHN1Ym1pc3Npb24KPiB2MjogTWlycm9yIGNoZWNrcyBmb3IgU0hUX1JFTCBjYXNl Lgo+IC0tLQo+ICB4ZW4vYXJjaC94ODYvbGl2ZXBhdGNoLmMgICB8IDEyIC0tLS0tLS0tLS0tLQo+ ICB4ZW4vY29tbW9uL2xpdmVwYXRjaF9lbGYuYyB8IDE3ICsrKysrKysrKysrKysrKysrCj4gIDIg ZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9saXZlcGF0Y2guYyBiL3hlbi9hcmNoL3g4Ni9saXZlcGF0 Y2guYwo+IGluZGV4IDk1MmU4OTcuLjViMGM4NjMgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2 L2xpdmVwYXRjaC5jCj4gKysrIGIveGVuL2FyY2gveDg2L2xpdmVwYXRjaC5jCj4gQEAgLTE0Niwx OCArMTQ2LDYgQEAgaW50IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm1fcmVsYShzdHJ1Y3QgbGl2ZXBh dGNoX2VsZiAqZWxmLAo+ICAgICAgdWludDY0X3QgdmFsOwo+ICAgICAgdWludDhfdCAqZGVzdDsK PiAgCj4gLSAgICAvKiBOb3RoaW5nIHRvIGRvLiAqLwo+IC0gICAgaWYgKCAhcmVsYS0+c2VjLT5z aF9zaXplICkKPiAtICAgICAgICByZXR1cm4gMDsKPiAtCj4gLSAgICBpZiAoIHJlbGEtPnNlYy0+ c2hfZW50c2l6ZSA8IHNpemVvZihFbGZfUmVsQSkgfHwKPiAtICAgICAgICAgcmVsYS0+c2VjLT5z aF9zaXplICUgcmVsYS0+c2VjLT5zaF9lbnRzaXplICkKPiAtICAgIHsKPiAtICAgICAgICBkcHJp bnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IFNlY3Rpb24gcmVsYXRpdmUgaGVhZGVyIGlz IGNvcnJ1cHRlZCFcbiIsCj4gLSAgICAgICAgICAgICAgICBlbGYtPm5hbWUpOwo+IC0gICAgICAg IHJldHVybiAtRUlOVkFMOwo+IC0gICAgfQo+IC0KPiAgICAgIGZvciAoIGkgPSAwOyBpIDwgKHJl bGEtPnNlYy0+c2hfc2l6ZSAvIHJlbGEtPnNlYy0+c2hfZW50c2l6ZSk7IGkrKyApCj4gICAgICB7 Cj4gICAgICAgICAgciA9IHJlbGEtPmRhdGEgKyBpICogcmVsYS0+c2VjLT5zaF9lbnRzaXplOwo+ IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL2xpdmVwYXRjaF9lbGYuYyBiL3hlbi9jb21tb24vbGl2 ZXBhdGNoX2VsZi5jCj4gaW5kZXggNzg5ZThmYy4uY2RhOWIyNyAxMDA2NDQKPiAtLS0gYS94ZW4v Y29tbW9uL2xpdmVwYXRjaF9lbGYuYwo+ICsrKyBiL3hlbi9jb21tb24vbGl2ZXBhdGNoX2VsZi5j Cj4gQEAgLTMzNSw2ICszMzUsNyBAQCBpbnQgbGl2ZXBhdGNoX2VsZl9wZXJmb3JtX3JlbG9jcyhz dHJ1Y3QgbGl2ZXBhdGNoX2VsZiAqZWxmKQo+ICAgICAgc3RydWN0IGxpdmVwYXRjaF9lbGZfc2Vj ICpyLCAqYmFzZTsKPiAgICAgIHVuc2lnbmVkIGludCBpOwo+ICAgICAgaW50IHJjID0gMDsKPiAr ICAgIHNpemVfdCBzejsKPiAgCj4gICAgICBBU1NFUlQoZWxmLT5zeW0pOwo+ICAKPiBAQCAtMzY1 LDYgKzM2NiwyMiBAQCBpbnQgbGl2ZXBhdGNoX2VsZl9wZXJmb3JtX3JlbG9jcyhzdHJ1Y3QgbGl2 ZXBhdGNoX2VsZiAqZWxmKQo+ICAgICAgICAgIH0KPiAgCj4gICAgICAgICAgaWYgKCByLT5zZWMt PnNoX3R5cGUgPT0gU0hUX1JFTEEgKQo+ICsgICAgICAgICAgICBzeiA9IHNpemVvZihFbGZfUmVs QSk7Cj4gKyAgICAgICAgZWxzZQo+ICsgICAgICAgICAgICBzeiA9IHNpemVvZihFbGZfUmVsKTsK PiArCj4gKyAgICAgICAgaWYgKCAhci0+c2VjLT5zaF9zaXplICkKPiArICAgICAgICAgICAgY29u dGludWU7Cj4gKwo+ICsgICAgICAgIGlmICggci0+c2VjLT5zaF9lbnRzaXplIDwgc3ogfHwgci0+ c2VjLT5zaF9zaXplICUgci0+c2VjLT5zaF9lbnRzaXplICkKPiArICAgICAgICB7Cj4gKyAgICAg ICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiwgTElWRVBBVENIICIlczogU2VjdGlvbiByZWxhdGl2 ZSBoZWFkZXIgaXMgY29ycnVwdGVkIVxuIiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5h bWUpOwo+ICsgICAgICAgICAgICByYyA9IC1FSU5WQUw7Cj4gKyAgICAgICAgICAgIGJyZWFrOwo+ ICsgICAgICAgIH0KPiArCj4gKyAgICAgICAgaWYgKCByLT5zZWMtPnNoX3R5cGUgPT0gU0hUX1JF TEEgKQo+ICAgICAgICAgICAgICByYyA9IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm1fcmVsYShlbGYs IGJhc2UsIHIpOwo+ICAgICAgICAgIGVsc2UgLyogU0hUX1JFTCAqLwo+ICAgICAgICAgICAgICBy YyA9IGFyY2hfbGl2ZXBhdGNoX3BlcmZvcm1fcmVsKGVsZiwgYmFzZSwgcik7Cj4gLS0gCj4gMi40 LjExCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpY ZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK