diff for duplicates of <20160906195149.GJ9040@lukather> diff --git a/a/1.txt b/N1/1.txt index f9882f4..b11e4d1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -24,34 +24,34 @@ On Tue, Sep 06, 2016 at 09:12:56AM +0200, Olliver Schinagl wrote: > > > > > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl> > > > --- -> > > drivers/pwm/pwm-sun4i.c | 11 +++++++++++ -> > > 1 file changed, 11 insertions(+) +> > > ?drivers/pwm/pwm-sun4i.c | 11 +++++++++++ +> > > ?1 file changed, 11 insertions(+) > > > > > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c > > > index 03a99a5..5e97c8a 100644 > > > --- a/drivers/pwm/pwm-sun4i.c > > > +++ b/drivers/pwm/pwm-sun4i.c > > > @@ -8,6 +8,7 @@ -> > > -> > > #include <linux/bitops.h> -> > > #include <linux/clk.h> +> > > ? +> > > ?#include <linux/bitops.h> +> > > ?#include <linux/clk.h> > > > +#include <linux/delay.h> -> > > #include <linux/err.h> -> > > #include <linux/io.h> -> > > #include <linux/module.h> +> > > ?#include <linux/err.h> +> > > ?#include <linux/io.h> +> > > ?#include <linux/module.h> > > > @@ -245,6 +246,16 @@ static void sun4i_pwm_disable(struct pwm_chip > > > *chip, struct pwm_device *pwm) -> > > spin_lock(&sun4i_pwm->ctrl_lock); -> > > val = sun4i_pwm_readl(sun4i_pwm, PWM_CTRL_REG); -> > > val &= ~BIT_CH(PWM_EN, pwm->hwpwm); +> > > ? spin_lock(&sun4i_pwm->ctrl_lock); +> > > ? val = sun4i_pwm_readl(sun4i_pwm, PWM_CTRL_REG); +> > > ? val &= ~BIT_CH(PWM_EN, pwm->hwpwm); > > > + sun4i_pwm_writel(sun4i_pwm, val, PWM_CTRL_REG); > > > + spin_unlock(&sun4i_pwm->ctrl_lock); > > > + > > > + /* Allow for the PWM hardware to finish its last toggle. > > > The pulse -> > > + * may have just started and thus we should wait a full +> > > + ?* may have just started and thus we should wait a full > > > period. -> > > + */ +> > > + ?*/ > > > + ndelay(pwm_get_period(pwm)); > > > > Can't that use the ready bit as well? @@ -74,3 +74,10 @@ Maxime Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com +-------------- next part -------------- +A non-text attachment was scrubbed... +Name: signature.asc +Type: application/pgp-signature +Size: 819 bytes +Desc: not available +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160906/70528e0f/attachment.sig> diff --git a/a/2.bin b/a/2.bin deleted file mode 100644 index b7f6223..0000000 --- a/a/2.bin +++ /dev/null @@ -1,17 +0,0 @@ ------BEGIN PGP SIGNATURE----- -Version: GnuPG v1 - -iQIcBAEBAgAGBQJXzx5VAAoJEBx+YmzsjxAgdtUP/0/UHtGcf/urEmamxPKkehfP -hDyUJ4qQK6S2UMngiWcGXoB3EsJaWPrMgOlmeTqTQoW+oztLEgM8eARcMZOqxy+3 -S173FhVz8qUoQn0o4rCT/3kM6gHu4+DXNsYYuC2v3XM7eN8smLnyIK7VvnmcMKw5 -pwJONRqyxr7PrjL4BGnaqIDqIPJO3eOXexTLBkFYuq7J40XD6SMpomiks6o4o+1g -nD1I4EzICvgr+Yx2kEDJA2gRGWRJaiucnVY1Lf0TyPLFxV+MbU27zXSOaqpVIn67 -SJ+QxsR+WBKb6pOR2jTCzoKm/1dSXFoaTGEUu2uwCqLjMoY2jQVzySdRq9Lxieic -WDwNBFF6y1/3iDEtA5LMQG+U0CyssJfjj55sqAdGlk3WdEWY7TAYTGRbFM9RvmeL -kJmS97Of8w5Y3lBX7vFv/R9P2Hrklkq6Ln6/hPsGSIeI+jgX/lA+sOEcUjgZ0IWD -FThCqmP/5iolWfVVwNagGa/Xrs7is0r7FxX7pWvwbknArs9vr+U6UPLc/Yd/F2F4 -fGnEcbV8sYcPaZ7Xgiel7PVDchMt/R7uaj1+bZth7PRZbEm2Jj3yZyvggKYDoaN2 -7M3jUYEWkTrmaM7vx7ua2vVNr4iJr8lF5X+hgaqOruk4kgZr1aqLiH/OvGTOHxZU -3BOStbQiHlw8ETQaPikX -=oIKq ------END PGP SIGNATURE----- diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index 5e5352c..0000000 --- a/a/2.hdr +++ /dev/null @@ -1 +0,0 @@ -Content-Type: application/pgp-signature; name="signature.asc" diff --git a/a/content_digest b/N1/content_digest index 4121115..2e5804b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,17 +2,11 @@ "ref\01472147411-30424-2-git-send-email-oliver@schinagl.nl\0" "ref\020160826221900.GG3165@lukather\0" "ref\01473145976.731.20.camel@schinagl.nl\0" - "From\0Maxime Ripard <maxime.ripard@free-electrons.com>\0" - "Subject\0Re: [PATCH 1/2] pwm: sunxi: allow the pwm to finish its pulse before disable\0" + "From\0maxime.ripard@free-electrons.com (Maxime Ripard)\0" + "Subject\0[PATCH 1/2] pwm: sunxi: allow the pwm to finish its pulse before disable\0" "Date\0Tue, 6 Sep 2016 21:51:49 +0200\0" - "To\0Olliver Schinagl <oliver@schinagl.nl>\0" - "Cc\0Alexandre Belloni <alexandre.belloni@free-electrons.com>" - Thierry Reding <thierry.reding@gmail.com> - Chen-Yu Tsai <wens@csie.org> - linux-pwm@vger.kernel.org - linux-arm-kernel@lists.infradead.org - " linux-kernel@vger.kernel.org\0" - "\01:1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" "On Tue, Sep 06, 2016 at 09:12:56AM +0200, Olliver Schinagl wrote:\n" "> Hi Maxime!,\n" @@ -40,34 +34,34 @@ "> > > \n" "> > > Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>\n" "> > > ---\n" - "> > > \302\240drivers/pwm/pwm-sun4i.c | 11 +++++++++++\n" - "> > > \302\2401 file changed, 11 insertions(+)\n" + "> > > ?drivers/pwm/pwm-sun4i.c | 11 +++++++++++\n" + "> > > ?1 file changed, 11 insertions(+)\n" "> > > \n" "> > > diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c\n" "> > > index 03a99a5..5e97c8a 100644\n" "> > > --- a/drivers/pwm/pwm-sun4i.c\n" "> > > +++ b/drivers/pwm/pwm-sun4i.c\n" "> > > @@ -8,6 +8,7 @@\n" - "> > > \302\240\n" - "> > > \302\240#include <linux/bitops.h>\n" - "> > > \302\240#include <linux/clk.h>\n" + "> > > ?\n" + "> > > ?#include <linux/bitops.h>\n" + "> > > ?#include <linux/clk.h>\n" "> > > +#include <linux/delay.h>\n" - "> > > \302\240#include <linux/err.h>\n" - "> > > \302\240#include <linux/io.h>\n" - "> > > \302\240#include <linux/module.h>\n" + "> > > ?#include <linux/err.h>\n" + "> > > ?#include <linux/io.h>\n" + "> > > ?#include <linux/module.h>\n" "> > > @@ -245,6 +246,16 @@ static void sun4i_pwm_disable(struct pwm_chip\n" "> > > *chip, struct pwm_device *pwm)\n" - "> > > \302\240\tspin_lock(&sun4i_pwm->ctrl_lock);\n" - "> > > \302\240\tval = sun4i_pwm_readl(sun4i_pwm, PWM_CTRL_REG);\n" - "> > > \302\240\tval &= ~BIT_CH(PWM_EN, pwm->hwpwm);\n" + "> > > ?\tspin_lock(&sun4i_pwm->ctrl_lock);\n" + "> > > ?\tval = sun4i_pwm_readl(sun4i_pwm, PWM_CTRL_REG);\n" + "> > > ?\tval &= ~BIT_CH(PWM_EN, pwm->hwpwm);\n" "> > > +\tsun4i_pwm_writel(sun4i_pwm, val, PWM_CTRL_REG);\n" "> > > +\tspin_unlock(&sun4i_pwm->ctrl_lock);\n" "> > > +\n" "> > > +\t/* Allow for the PWM hardware to finish its last toggle.\n" "> > > The pulse\n" - "> > > +\t\302\240* may have just started and thus we should wait a full\n" + "> > > +\t?* may have just started and thus we should wait a full\n" "> > > period.\n" - "> > > +\t\302\240*/\n" + "> > > +\t?*/\n" "> > > +\tndelay(pwm_get_period(pwm));\n" "> > \n" "> > Can't that use the ready bit as well?\n" @@ -89,26 +83,13 @@ "-- \n" "Maxime Ripard, Free Electrons\n" "Embedded Linux and Kernel engineering\n" - http://free-electrons.com - "\01:2\0" - "fn\0signature.asc\0" - "b\0" - "-----BEGIN PGP SIGNATURE-----\n" - "Version: GnuPG v1\n" - "\n" - "iQIcBAEBAgAGBQJXzx5VAAoJEBx+YmzsjxAgdtUP/0/UHtGcf/urEmamxPKkehfP\n" - "hDyUJ4qQK6S2UMngiWcGXoB3EsJaWPrMgOlmeTqTQoW+oztLEgM8eARcMZOqxy+3\n" - "S173FhVz8qUoQn0o4rCT/3kM6gHu4+DXNsYYuC2v3XM7eN8smLnyIK7VvnmcMKw5\n" - "pwJONRqyxr7PrjL4BGnaqIDqIPJO3eOXexTLBkFYuq7J40XD6SMpomiks6o4o+1g\n" - "nD1I4EzICvgr+Yx2kEDJA2gRGWRJaiucnVY1Lf0TyPLFxV+MbU27zXSOaqpVIn67\n" - "SJ+QxsR+WBKb6pOR2jTCzoKm/1dSXFoaTGEUu2uwCqLjMoY2jQVzySdRq9Lxieic\n" - "WDwNBFF6y1/3iDEtA5LMQG+U0CyssJfjj55sqAdGlk3WdEWY7TAYTGRbFM9RvmeL\n" - "kJmS97Of8w5Y3lBX7vFv/R9P2Hrklkq6Ln6/hPsGSIeI+jgX/lA+sOEcUjgZ0IWD\n" - "FThCqmP/5iolWfVVwNagGa/Xrs7is0r7FxX7pWvwbknArs9vr+U6UPLc/Yd/F2F4\n" - "fGnEcbV8sYcPaZ7Xgiel7PVDchMt/R7uaj1+bZth7PRZbEm2Jj3yZyvggKYDoaN2\n" - "7M3jUYEWkTrmaM7vx7ua2vVNr4iJr8lF5X+hgaqOruk4kgZr1aqLiH/OvGTOHxZU\n" - "3BOStbQiHlw8ETQaPikX\n" - "=oIKq\n" - "-----END PGP SIGNATURE-----\n" + "http://free-electrons.com\n" + "-------------- next part --------------\n" + "A non-text attachment was scrubbed...\n" + "Name: signature.asc\n" + "Type: application/pgp-signature\n" + "Size: 819 bytes\n" + "Desc: not available\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160906/70528e0f/attachment.sig> -07831e239215599e9eea69f2e97dd028285cdf6fd0ad8f9ee3f772b521036838 +26826978ea3105df9e08ae923b78ec23c6199439cc5f893a6719903453a32401
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.