From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Wed, 7 Sep 2016 04:03:16 +0200 Subject: [PATCH 3/4] ARM: orion5x: avoid NO_IRQ in orion_ge00_switch_init In-Reply-To: <20160906140623.2853066-3-arnd@arndb.de> References: <20160906140623.2853066-1-arnd@arndb.de> <20160906140623.2853066-3-arnd@arndb.de> Message-ID: <20160907020316.GC10007@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 06, 2016 at 04:06:22PM +0200, Arnd Bergmann wrote: > As of commit 5be9fc23cdb4 ("ARM: orion5x: fix legacy orion5x IRQ numbers"), > IRQ zero is no longer a valid interrupt on Orion5x, so we can use the > normal convention of using '0' to indicate an invalid interrupt, rather > than the deprecated NO_IRQ constant > > My first approach was to pass a pointer to the resource into > orion_ge00_switch_init(), but it seemed to just add complexity > for no good. Hi Arnd You can simply this. DSA has never as far as i remember used an interrupt passed via platform data. Two boards do seem to pass an interrupt via a GPIO line, but it has never been used. So if you want, you could strip all this interrupt code out. There might be some patches coming soon which does add interrupt support to DSA, but it will only be via device tree, since i don't have a platform which is capable of using platform data for DSA. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756317AbcIGCDY (ORCPT ); Tue, 6 Sep 2016 22:03:24 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:37247 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756047AbcIGCDX (ORCPT ); Tue, 6 Sep 2016 22:03:23 -0400 Date: Wed, 7 Sep 2016 04:03:16 +0200 From: Andrew Lunn To: Arnd Bergmann Cc: Jason Cooper , Gregory Clement , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ARM: orion5x: avoid NO_IRQ in orion_ge00_switch_init Message-ID: <20160907020316.GC10007@lunn.ch> References: <20160906140623.2853066-1-arnd@arndb.de> <20160906140623.2853066-3-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160906140623.2853066-3-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 06, 2016 at 04:06:22PM +0200, Arnd Bergmann wrote: > As of commit 5be9fc23cdb4 ("ARM: orion5x: fix legacy orion5x IRQ numbers"), > IRQ zero is no longer a valid interrupt on Orion5x, so we can use the > normal convention of using '0' to indicate an invalid interrupt, rather > than the deprecated NO_IRQ constant > > My first approach was to pass a pointer to the resource into > orion_ge00_switch_init(), but it seemed to just add complexity > for no good. Hi Arnd You can simply this. DSA has never as far as i remember used an interrupt passed via platform data. Two boards do seem to pass an interrupt via a GPIO line, but it has never been used. So if you want, you could strip all this interrupt code out. There might be some patches coming soon which does add interrupt support to DSA, but it will only be via device tree, since i don't have a platform which is capable of using platform data for DSA. Andrew