From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhSRx-0006Bh-8p for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:18:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhSRw-0001mg-Cg for qemu-devel@nongnu.org; Tue, 06 Sep 2016 22:18:53 -0400 Date: Wed, 7 Sep 2016 10:18:44 +0800 From: Fam Zheng Message-ID: <20160907021844.GA15671@lemon> References: <1470662013-19785-1-git-send-email-famz@redhat.com> <1470662013-19785-4-git-send-email-famz@redhat.com> <20160906163324.GH4667@noname.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160906163324.GH4667@noname.redhat.com> Subject: Re: [Qemu-devel] [PATCH v7 03/20] block: Add and parse "lock-mode" option for image locking List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, rjones@redhat.com, John Snow , Jeff Cody , Markus Armbruster , Max Reitz , stefanha@redhat.com, den@openvz.org, pbonzini@redhat.com, berrange@redhat.com On Tue, 09/06 18:33, Kevin Wolf wrote: > > + lock_mode = qemu_opt_get(opts, BDRV_OPT_LOCK_MODE) ? : "off"; > > Am I missing some other place that overrides this or does it make the > default "off" rather than "auto"? It is in patch 19, once all tests are fixed (this patch cannot be reordered after tests fixing because it involves specifying the lock-mode option.)