From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: souvikdey33 <sodey@sonusnet.com>,
stephen@networkplumber.org, huawei.xie@intel.com, dev@dpdk.org
Subject: Re: [PATCH v2] add mtu set in virtio
Date: Wed, 7 Sep 2016 11:25:47 +0800 [thread overview]
Message-ID: <20160907032547.GG23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <d6819eae-3fa5-4a77-bd27-084019852fdc@redhat.com>
On Tue, Aug 30, 2016 at 09:57:39AM +0200, Maxime Coquelin wrote:
> Hi Souvik,
>
> On 08/30/2016 01:02 AM, souvikdey33 wrote:
> >Signed-off-by: Souvik Dey <sodey@sonusnet.com>
> >
> >Fixes: 1fb8e8896ca8 ("Signed-off-by: Souvik Dey <sodey@sonusnet.com>")
> >Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> >Virtio interfaces should also support setting of mtu, as in case of cloud
> >it is expected to have the consistent mtu across the infrastructure that
> >the dhcp server sends and not hardcoded to 1500(default).
> >---
> > drivers/net/virtio/virtio_ethdev.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
>
> FYI, there are some on-going changes in the VIRTIO specification
> so that the VHOST interface exposes its MTU to its VIRTIO peer.
> It may also be used as an alternative of what you patch achieves.
>
> I am working on its implementation in Qemu/DPDK, our goal being to
> reduce performance drops for small packets with Rx mergeable buffers
> feature enabled.
Mind to educate me a bit on how that works?
--yliu
next prev parent reply other threads:[~2016-09-07 3:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 23:02 [PATCH v2] add mtu set in virtio souvikdey33
2016-08-30 7:57 ` Maxime Coquelin
2016-09-01 22:20 ` Dey, Souvik
2016-09-02 7:05 ` Maxime Coquelin
2016-09-07 2:11 ` Dey, Souvik
2016-09-07 8:28 ` Maxime Coquelin
2016-09-07 3:25 ` Yuanhan Liu [this message]
2016-09-07 9:16 ` Maxime Coquelin
2016-09-08 7:30 ` Yuanhan Liu
2016-09-08 7:50 ` Maxime Coquelin
2016-09-08 7:57 ` Yuanhan Liu
2016-09-09 3:44 ` Dey, Souvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907032547.GG23158@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=sodey@sonusnet.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.