From: Stephen Hemminger <stephen@networkplumber.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"Yaogong Wang" <wygivan@google.com>,
"Yuchung Cheng" <ycheng@google.com>,
"Neal Cardwell" <ncardwell@google.com>,
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Subject: Re: [PATCH net-next] tcp: use an RB tree for ooo receive queue
Date: Wed, 7 Sep 2016 15:26:37 -0700 [thread overview]
Message-ID: <20160907152637.7df3f9d9@xeon-e3> (raw)
In-Reply-To: <1473284968.15733.8.camel@edumazet-glaptop3.roam.corp.google.com>
On Wed, 07 Sep 2016 14:49:28 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Yaogong Wang <wygivan@google.com>
>
> Over the years, TCP BDP has increased by several orders of magnitude,
> and some people are considering to reach the 2 Gbytes limit.
>
> Even with current window scale limit of 14, ~1 Gbytes maps to ~740,000
> MSS.
>
> In presence of packet losses (or reorders), TCP stores incoming packets
> into an out of order queue, and number of skbs sitting there waiting for
> the missing packets to be received can be in the 10^5 range.
>
> Most packets are appended to the tail of this queue, and when
> packets can finally be transferred to receive queue, we scan the queue
> from its head.
>
> However, in presence of heavy losses, we might have to find an arbitrary
> point in this queue, involving a linear scan for every incoming packet,
> throwing away cpu caches.
>
> This patch converts it to a RB tree, to get bounded latencies.
>
> Yaogong wrote a preliminary patch about 2 years ago.
> Eric did the rebase, added ofo_last_skb cache, polishing and tests.
>
> Tested with network dropping between 1 and 10 % packets, with good
> success (about 30 % increase of throughput in stress tests)
>
> Next step would be to also use an RB tree for the write queue at sender
> side ;)
>
> Signed-off-by: Yaogong Wang <wygivan@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Yuchung Cheng <ycheng@google.com>
> Cc: Neal Cardwell <ncardwell@google.com>
> Cc: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
How much does this grow the size of tcp socket structure?
next prev parent reply other threads:[~2016-09-07 22:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 21:49 [PATCH net-next] tcp: use an RB tree for ooo receive queue Eric Dumazet
2016-09-07 22:26 ` Stephen Hemminger [this message]
2016-09-07 22:32 ` Eric Dumazet
2016-09-08 11:02 ` Ilpo Järvinen
2016-09-08 13:38 ` Eric Dumazet
2016-09-08 14:31 ` Nicolas Dichtel
2016-09-09 0:26 ` David Miller
2016-09-09 0:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907152637.7df3f9d9@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=wygivan@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.