From: Richard Cochran <richardcochran@gmail.com>
To: Daniel Walker <danielwa@cisco.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xe-kernel@external.cisco.com" <xe-kernel@external.cisco.com>,
"Shabeena Shabeena -X (sshabeen - ARICENT TECHNOLOGIES
MAURIITIUS LIMITED at Cisco)" <sshabeen@cisco.com>
Subject: Re: ptp
Date: Wed, 7 Sep 2016 22:48:18 +0200 [thread overview]
Message-ID: <20160907204818.GA7470@localhost.localdomain> (raw)
In-Reply-To: <d1b2b740-8cc6-bf4a-722b-7b323fb0c7c0@cisco.com>
On Wed, Sep 07, 2016 at 01:40:59PM -0700, Daniel Walker wrote:
> There is a test (below) , which prevents negative nanosecond updates. The
> code below would force a negative update to always return more than
> NSEC_PER_SEC. It should be using abs() instead which would return the value
> desired.
No. This:
/*
* The value of a timeval is the sum of its fields, but the
* field tv_usec must always be non-negative.
*/
HTH,
Richard
next parent reply other threads:[~2016-09-07 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d1b2b740-8cc6-bf4a-722b-7b323fb0c7c0@cisco.com>
2016-09-07 20:48 ` Richard Cochran [this message]
2016-09-07 20:55 ` ptp Daniel Walker
2016-09-07 21:12 ` ptp Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160907204818.GA7470@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=danielwa@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=sshabeen@cisco.com \
--cc=xe-kernel@external.cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.