Re: [PATCH 2/3] x86: add support for L2 CAT in hypervisor.

[Yi Sun <yi.y.sun@linux.intel.com>]

On 16-09-07 03:03:12, Jan Beulich wrote:
> >>> On 07.09.16 at 09:13, <yi.y.sun@linux.intel.com> wrote:
> > On 16-09-06 01:43:22, Jan Beulich wrote:
> >> >>> On 25.08.16 at 07:22, <yi.y.sun@linux.intel.com> wrote:
> >> 
> >> Please extend the comments given for patch 1 to this one. Just one
> >> extra thing:
> >> 
> >> > @@ -743,7 +744,7 @@ struct xen_sysctl_psr_cat_op {
> >> >              uint32_t cos_max;   /* OUT: Maximum COS */
> >> >  #define XEN_SYSCTL_PSR_CAT_L3_CDP       (1u << 0)
> >> >              uint32_t flags;     /* OUT: CAT flags */
> >> > -        } l3_info;
> >> > +        } info;
> >> 
> >> Such an adjustment breaks the tools build, i.e. can't come without
> >> also minimally adjusting libxc.
> >> 
> >> Jan
> > I thought 4.8 will also make tools version upgrade but not considered
> > to be compatible with old tools. Sorry for that.
> > 
> > Considering the compatibility and to support future feature, I want to
> > add a general structure in union, like below. How do you think? Thanks!
> 
> No, you don't need to be compatible with old tools. But you need to
> avoid build breakage between patches 2 and 3. Please always
> remember that (a) patch series may not get applied in one go and
> (b) even if they do any intermediate build breakage will hinder
> bisection attempts.
> 
> Jan

Got it. Thanks a lot for your explanation!


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel