From: Pablo Neira Ayuso <pablo@netfilter.org>
To: fgao@ikuai8.com
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
gfree.wind@gmail.com
Subject: Re: [PATCH nf-next] netfilter: xt_TEE: Add the missed return value check in tee_tg_check
Date: Thu, 8 Sep 2016 10:34:22 +0200 [thread overview]
Message-ID: <20160908083422.GA1967@salvia> (raw)
In-Reply-To: <1473304976-9899-1-git-send-email-fgao@ikuai8.com>
On Thu, Sep 08, 2016 at 11:22:56AM +0800, fgao@ikuai8.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> The original codes didn't check the return value of function
> register_netdevice_notifier.
net/netfilter/nf_tables_netdev.c: register_netdevice_notifier(&nf_tables_netdev_notifier);
net/netfilter/nfnetlink_queue.c: register_netdevice_notifier(&nfqnl_dev_notifier);
I can track a few more calls in the netfilter tree, I'd suggest you
fix them in one go given they are part of the same logical change
(they fit very weel into one single patch description).
Thanks!
prev parent reply other threads:[~2016-09-08 8:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 3:22 [PATCH nf-next] netfilter: xt_TEE: Add the missed return value check in tee_tg_check fgao
2016-09-08 8:34 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908083422.GA1967@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.