From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhwQ9-0000Bs-Cj for qemu-devel@nongnu.org; Thu, 08 Sep 2016 06:19:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhwQ5-00078K-1s for qemu-devel@nongnu.org; Thu, 08 Sep 2016 06:19:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhwQ4-00077s-SY for qemu-devel@nongnu.org; Thu, 08 Sep 2016 06:18:56 -0400 Date: Thu, 8 Sep 2016 12:18:53 +0200 From: Kevin Wolf Message-ID: <20160908101853.GC4206@noname.redhat.com> References: <1471935390-126476-1-git-send-email-ashish.mittal@veritas.com> <20160830173507.GA1501@localhost.localdomain> <20160908084319.GA4206@noname.redhat.com> <20160908084922.GC30602@redhat.com> <20160908092941.GB4206@noname.redhat.com> <20160908094358.GF30602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160908094358.GF30602@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: ashish mittal , Jeff Cody , qemu-devel@nongnu.org, Paolo Bonzini , Markus Armbruster , Ashish Mittal , Stefan Hajnoczi , Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com Am 08.09.2016 um 11:43 hat Daniel P. Berrange geschrieben: > On Thu, Sep 08, 2016 at 11:29:41AM +0200, Kevin Wolf wrote: > > Am 08.09.2016 um 10:49 hat Daniel P. Berrange geschrieben: > > > On Thu, Sep 08, 2016 at 10:43:19AM +0200, Kevin Wolf wrote: > > > > Am 08.09.2016 um 00:32 hat ashish mittal geschrieben: > > > > > >> + > > > > > >> +void vxhs_set_acb_buffer(void *ptr, void *buffer) > > > > > >> +{ > > > > > >> + VXHSAIOCB *acb = ptr; > > > > > >> + > > > > > >> + acb->buffer = buffer; > > > > > >> +} > > > > > >> + > > > > > > > > > > > > Unused function? > > > > > > > > > > This is called from within libqnio. > > > > > > > > Wait, you mean the library references a symbol in the qemu binary? This > > > > sounds completely wrong to me. I wouldn't even do something like this if > > > > it were an internal qemu library because I think libraries should be > > > > self-contained, but it's a much larger problem in something that is > > > > supposed to be an independent library. > > > > > > I'd be surprised if that actually worked. If an external library wants > > > to refrence symbols in the QEMU binary, then QEMU would ned to be using > > > the -export-dynamic / -rdynamic linker flags to export all its symbols, > > > and AFAIK, we're not doing that. > > > > Hm, but if the function is really used by the library, how else would it > > be when its name isn't mentioned anywhere in the patch except in its > > declaration? And it appears to be called there directly: > > > > https://github.com/MittalAshish/libqnio/search?q=vxhs_set_acb_buffer > > > > Anyway, something is fishy here. > > Oh, notice that .c file is actually part of the shim library, not the > main libqnio.so that QEMU would link against. > > So, it really is unused and should be deleted from this block/vxhs.c > file. I haven't fully understood yet what's the deal with this shim library, but this patch links against both. Kevin