diff for duplicates of <20160908105707.GA17331@node> diff --git a/a/1.txt b/N1/1.txt index 8e65464..8ba79e4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu wrote: > > > > > > > > > > > > When CONFIG_FS_DAX_PMD is set, DAX supports mmap() using pmd page -> > > > size.��This feature relies on both mmap virtual address and FS +> > > > size. This feature relies on both mmap virtual address and FS > > > > block (i.e. physical address) to be aligned by the pmd page size. > > > > Users can use mkfs options to specify FS to align block > > > > allocations. However, aligning mmap address requires code changes @@ -30,24 +30,24 @@ On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu wrote: > > > functionality in multiple places. > > > > Here is my brief analysis when I had looked at the Hugh's patch last -> > time (before�shmem_get_unmapped_area() was accepted). +> > time (before shmem_get_unmapped_area() was accepted). > > https://patchwork.kernel.org/patch/8916741/ > > > > Besides some differences in the logic, ex. shmem_get_unmapped_area() -> > always calls�current->mm->get_unmapped_area twice, yes, they +> > always calls current->mm->get_unmapped_area twice, yes, they > > basically provide the same functionality. > > > > I think one issue is that shmem_get_unmapped_area() checks with its > > static flag 'shmem_huge', and additinally deals with SHMEM_HUGE_DENY -> > and�SHMEM_HUGE_FORCE cases. �It also handles non-file case for +> > and SHMEM_HUGE_FORCE cases. It also handles non-file case for > > !SHMEM_HUGE_FORCE. > > Looking further, these shmem_huge handlings only check pre-conditions. -> �So, we should be able to make shmem_get_unmapped_area() as a wrapper, +> So, we should be able to make shmem_get_unmapped_area() as a wrapper, > which checks such shmem-specific conitions, and then -> call�__thp_get_unmapped_area() for the actual work. �All DAX-specific -> checks are performed in thp_get_unmapped_area() as well. �We can make -> �__thp_get_unmapped_area() as a common function. +> call __thp_get_unmapped_area() for the actual work. All DAX-specific +> checks are performed in thp_get_unmapped_area() as well. We can make +> __thp_get_unmapped_area() as a common function. > > I'd prefer to make such change as a separate item, diff --git a/a/content_digest b/N1/content_digest index c513ad6..59a1ebb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -32,7 +32,7 @@ "> > > > \n" "> > > > \n" "> > > > When CONFIG_FS_DAX_PMD is set, DAX supports mmap() using pmd page\n" - "> > > > size.\303\257\302\277\302\275\303\257\302\277\302\275This feature relies on both mmap virtual address and FS\n" + "> > > > size. This feature relies on both mmap virtual address and FS\n" "> > > > block (i.e. physical address) to be aligned by the pmd page size.\n" "> > > > Users can use mkfs options to specify FS to align block\n" "> > > > allocations. However, aligning mmap address requires code changes\n" @@ -56,24 +56,24 @@ "> > > functionality in multiple places.\n" "> > \n" "> > Here is my brief analysis when I had looked at the Hugh's patch last\n" - "> > time (before\303\257\302\277\302\275shmem_get_unmapped_area() was accepted).\n" + "> > time (before shmem_get_unmapped_area() was accepted).\n" "> > https://patchwork.kernel.org/patch/8916741/\n" "> > \n" "> > Besides some differences in the logic, ex. shmem_get_unmapped_area()\n" - "> > always calls\303\257\302\277\302\275current->mm->get_unmapped_area twice, yes, they\n" + "> > always calls current->mm->get_unmapped_area twice, yes, they\n" "> > basically provide the same functionality.\n" "> > \n" "> > I think one issue is that shmem_get_unmapped_area() checks with its\n" "> > static flag 'shmem_huge', and additinally deals with SHMEM_HUGE_DENY\n" - "> > and\303\257\302\277\302\275SHMEM_HUGE_FORCE cases. \303\257\302\277\302\275It also handles non-file case for\n" + "> > and SHMEM_HUGE_FORCE cases. It also handles non-file case for\n" "> > !SHMEM_HUGE_FORCE.\n" "> \n" "> Looking further, these shmem_huge handlings only check pre-conditions.\n" - "> \303\257\302\277\302\275So, we should be able to make shmem_get_unmapped_area() as a wrapper,\n" + "> So, we should be able to make shmem_get_unmapped_area() as a wrapper,\n" "> which checks such shmem-specific conitions, and then\n" - "> call\303\257\302\277\302\275__thp_get_unmapped_area() for the actual work. \303\257\302\277\302\275All DAX-specific\n" - "> checks are performed in thp_get_unmapped_area() as well. \303\257\302\277\302\275We can make\n" - "> \303\257\302\277\302\275__thp_get_unmapped_area() as a common function.\n" + "> call __thp_get_unmapped_area() for the actual work. All DAX-specific\n" + "> checks are performed in thp_get_unmapped_area() as well. We can make\n" + "> __thp_get_unmapped_area() as a common function.\n" "> \n" "> I'd prefer to make such change as a separate item,\n" "\n" @@ -88,4 +88,4 @@ "see: http://www.linux-mm.org/ .\n" "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -a558b45e643c206b1dabc23d517ad67fc2c6ab920eb684bd2bf4591a71ea5454 +860abeae10b19a4cc2dc5089bacf433dd01c829194e92c30b19bf70a125c399d
diff --git a/a/1.txt b/N2/1.txt index 8e65464..25a857e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -6,7 +6,7 @@ On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu wrote: > > > > > > > > > > > > When CONFIG_FS_DAX_PMD is set, DAX supports mmap() using pmd page -> > > > size.��This feature relies on both mmap virtual address and FS +> > > > size. This feature relies on both mmap virtual address and FS > > > > block (i.e. physical address) to be aligned by the pmd page size. > > > > Users can use mkfs options to specify FS to align block > > > > allocations. However, aligning mmap address requires code changes @@ -30,24 +30,24 @@ On Mon, Aug 29, 2016 at 10:00:43PM +0000, Kani, Toshimitsu wrote: > > > functionality in multiple places. > > > > Here is my brief analysis when I had looked at the Hugh's patch last -> > time (before�shmem_get_unmapped_area() was accepted). +> > time (before shmem_get_unmapped_area() was accepted). > > https://patchwork.kernel.org/patch/8916741/ > > > > Besides some differences in the logic, ex. shmem_get_unmapped_area() -> > always calls�current->mm->get_unmapped_area twice, yes, they +> > always calls current->mm->get_unmapped_area twice, yes, they > > basically provide the same functionality. > > > > I think one issue is that shmem_get_unmapped_area() checks with its > > static flag 'shmem_huge', and additinally deals with SHMEM_HUGE_DENY -> > and�SHMEM_HUGE_FORCE cases. �It also handles non-file case for +> > and SHMEM_HUGE_FORCE cases. It also handles non-file case for > > !SHMEM_HUGE_FORCE. > > Looking further, these shmem_huge handlings only check pre-conditions. -> �So, we should be able to make shmem_get_unmapped_area() as a wrapper, +> So, we should be able to make shmem_get_unmapped_area() as a wrapper, > which checks such shmem-specific conitions, and then -> call�__thp_get_unmapped_area() for the actual work. �All DAX-specific -> checks are performed in thp_get_unmapped_area() as well. �We can make -> �__thp_get_unmapped_area() as a common function. +> call __thp_get_unmapped_area() for the actual work. All DAX-specific +> checks are performed in thp_get_unmapped_area() as well. We can make +> __thp_get_unmapped_area() as a common function. > > I'd prefer to make such change as a separate item, @@ -55,9 +55,3 @@ Do you have plan to submit such change? -- Kirill A. Shutemov - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N2/content_digest index c513ad6..96ecdef 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -16,7 +16,7 @@ dan.j.williams@intel.com <dan.j.williams@intel.com> mawilcox@microsoft.com <mawilcox@microsoft.com> akpm@linux-foundation.org <akpm@linux-foundation.org> - linux-nvdimm@lists.01.org <linux-nvdimm@lists.01.org> + linux-nvdimm@lists.01.org <linux-nvdimm@ml01.01.org> linux-fsdevel@vger.kernel.org <linux-fsdevel@vger.kernel.org> ross.zwisler@linux.intel.com <ross.zwisler@linux.intel.com> tytso@mit.edu <tytso@mit.edu> @@ -32,7 +32,7 @@ "> > > > \n" "> > > > \n" "> > > > When CONFIG_FS_DAX_PMD is set, DAX supports mmap() using pmd page\n" - "> > > > size.\303\257\302\277\302\275\303\257\302\277\302\275This feature relies on both mmap virtual address and FS\n" + "> > > > size.\302\240\302\240This feature relies on both mmap virtual address and FS\n" "> > > > block (i.e. physical address) to be aligned by the pmd page size.\n" "> > > > Users can use mkfs options to specify FS to align block\n" "> > > > allocations. However, aligning mmap address requires code changes\n" @@ -56,36 +56,30 @@ "> > > functionality in multiple places.\n" "> > \n" "> > Here is my brief analysis when I had looked at the Hugh's patch last\n" - "> > time (before\303\257\302\277\302\275shmem_get_unmapped_area() was accepted).\n" + "> > time (before\302\240shmem_get_unmapped_area() was accepted).\n" "> > https://patchwork.kernel.org/patch/8916741/\n" "> > \n" "> > Besides some differences in the logic, ex. shmem_get_unmapped_area()\n" - "> > always calls\303\257\302\277\302\275current->mm->get_unmapped_area twice, yes, they\n" + "> > always calls\302\240current->mm->get_unmapped_area twice, yes, they\n" "> > basically provide the same functionality.\n" "> > \n" "> > I think one issue is that shmem_get_unmapped_area() checks with its\n" "> > static flag 'shmem_huge', and additinally deals with SHMEM_HUGE_DENY\n" - "> > and\303\257\302\277\302\275SHMEM_HUGE_FORCE cases. \303\257\302\277\302\275It also handles non-file case for\n" + "> > and\302\240SHMEM_HUGE_FORCE cases. \302\240It also handles non-file case for\n" "> > !SHMEM_HUGE_FORCE.\n" "> \n" "> Looking further, these shmem_huge handlings only check pre-conditions.\n" - "> \303\257\302\277\302\275So, we should be able to make shmem_get_unmapped_area() as a wrapper,\n" + "> \302\240So, we should be able to make shmem_get_unmapped_area() as a wrapper,\n" "> which checks such shmem-specific conitions, and then\n" - "> call\303\257\302\277\302\275__thp_get_unmapped_area() for the actual work. \303\257\302\277\302\275All DAX-specific\n" - "> checks are performed in thp_get_unmapped_area() as well. \303\257\302\277\302\275We can make\n" - "> \303\257\302\277\302\275__thp_get_unmapped_area() as a common function.\n" + "> call\302\240__thp_get_unmapped_area() for the actual work. \302\240All DAX-specific\n" + "> checks are performed in thp_get_unmapped_area() as well. \302\240We can make\n" + "> \302\240__thp_get_unmapped_area() as a common function.\n" "> \n" "> I'd prefer to make such change as a separate item,\n" "\n" "Do you have plan to submit such change?\n" "\n" "-- \n" - " Kirill A. Shutemov\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + Kirill A. Shutemov -a558b45e643c206b1dabc23d517ad67fc2c6ab920eb684bd2bf4591a71ea5454 +4fc9e3180e69722c425815e64e4d588efb3a7f6837afb3378ae78e4966f2272a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.