From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965546AbcIHQl6 (ORCPT ); Thu, 8 Sep 2016 12:41:58 -0400 Received: from merlin.infradead.org ([205.233.59.134]:35156 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934620AbcIHQlr (ORCPT ); Thu, 8 Sep 2016 12:41:47 -0400 Date: Thu, 8 Sep 2016 18:41:35 +0200 From: Peter Zijlstra To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , linux-kernel@vger.kernel.org, andi@firstfloor.org, eranian@google.com, jolsa@kernel.org, torvalds@linux-foundation.org, davidcc@google.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, kan.liang@intel.com, khandual@linux.vnet.ibm.com Subject: Re: [RFC][PATCH 7/7] perf/annotate: Add branch stack / basic block information Message-ID: <20160908164135.GV10153@twins.programming.kicks-ass.net> References: <20160708133059.031522978@infradead.org> <20160708134113.718203556@infradead.org> <20160708145555.GB17466@gmail.com> <20160708162733.GJ30909@twins.programming.kicks-ass.net> <20160708163632.GK30927@twins.programming.kicks-ass.net> <20160908161857.GA4801@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160908161857.GA4801@kernel.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 08, 2016 at 01:18:57PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jul 08, 2016 at 06:36:32PM +0200, Peter Zijlstra escreveu: > > On Fri, Jul 08, 2016 at 06:27:33PM +0200, Peter Zijlstra wrote: > > > > > I've been thinking of filtering all targets and branches that are > > > smaller than 0.1% in order to avoid this, but so far I've just been > > > ignoring these things. > > > > Like so... seems to 'work'. > > So I merged this one with 7/7 and this is the result, screenshot to > capture the colors: > > http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png > > Please let me know if I should go ahead and push with the combined > patch, that is now at: > > https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/annotate_basic_blocks&id=baf41a43fa439ac534d21e41882a7858d5cee1e5 > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/annotate_basic_blocks > > Is that ok? > > The problem with it is that it is done only for --stdio, I'll check how > to properly make it UI agnostic... Yep, much thanks!