Re: [samba PATCH] vfs:ceph: convert to using ceph_statx structures and functions, when available

[Jeremy Allison <jra@samba.org>]

On Thu, Sep 08, 2016 at 10:35:55AM -0400, Jeff Layton wrote:
> On Thu, 2016-09-08 at 10:29 -0400, Jeff Layton wrote:
> > Add a configure test for the ceph_statx function, and use that to
> > determine whether to compile in new functions that use it and its
> > variants, or whether to use a the older code that fetches birthtimes
> > from an xattr.
> > 
> > For cephwrap_lstat, we can use ceph_statx with the AT_SYMLINK_NOFOLLOW
> > flag to get the right lookup semantics.
> > 
> > For setting the times via cephwrap_ntimes, We can just use ceph_setattrx
> > and pass them all in at the same time.
> > 
> > > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> > ---
> >  source3/modules/vfs_ceph.c | 216 ++++++++++++++++++++++++++++++++++++++-------
> >  source3/wscript            |   2 +
> >  2 files changed, 185 insertions(+), 33 deletions(-)
> > 
> 
> The new interfaces are now merged in the ceph master branch and should
> ship with the Kraken release. I know however, that Greg F. has some
> libcephfs API changes queued up that might change these function
> prototypes.
> 
> So, it may be good to hold off on merging this into samba master until
> his work has been merged.

Fair enough. I'll file these away in my samba-ceph folder until
you tell me to go look at them :-).

Cheers,

	Jeremy.