From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi0ui-0005V7-CP for qemu-devel@nongnu.org; Thu, 08 Sep 2016 11:06:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi0ud-0003bU-4v for qemu-devel@nongnu.org; Thu, 08 Sep 2016 11:06:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi0uc-0003bJ-Vp for qemu-devel@nongnu.org; Thu, 08 Sep 2016 11:06:47 -0400 Date: Thu, 8 Sep 2016 18:06:45 +0300 From: "Michael S. Tsirkin" Message-ID: <20160908180505-mutt-send-email-mst@kernel.org> References: <1473323650-13298-1-git-send-email-maxime.coquelin@redhat.com> <1473323650-13298-3-git-send-email-maxime.coquelin@redhat.com> <86AAE458-EC2F-4814-88A9-E3E7F93AD274@nutanix.com> <1848526494.767098.1473335798486.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1848526494.767098.1473335798486.JavaMail.zimbra@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] vhost-user: only seek a reply if needed in set_mem_table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: Maxime Coquelin , Prerna Saxena , qemu-devel@nongnu.org, marcandre lureau , peter maydell On Thu, Sep 08, 2016 at 07:56:38AM -0400, Marc-Andr=E9 Lureau wrote: > Hi >=20 > ----- Original Message ----- > > Regarding Patch 2/2: > > This patch seems to filter responses from set_mem_table only for cert= ain > > updates of memory regions. It violates the definition of the REPLY_AC= K > > feature. This feature expects the client to send a response for every= call > > of set_mem_table. And here, qemu exits the set_mem_table() function i= n some > > cases without even waiting for the reply that is going to come in. > >=20 >=20 > Agreed with Prerna here, >=20 > Furthermore, I haven't followed closely the recents developments, and t= he commit message doesn't explain why it should not be necessary to sync = the first time set-mem-table is called. Could you develop that? >=20 > thanks Basically if we send set mem table when backend is not started, there is no reason to wait for a response. --=20 MST