From: Andrew Lunn <andrew@lunn.ch>
To: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
Allan.Nielsen@microsemi.com
Subject: Re: [PATCH v2 net-next 2/2] net: phy: Add MAC-IF driver for Microsemi PHYs.
Date: Fri, 9 Sep 2016 14:03:46 +0200 [thread overview]
Message-ID: <20160909120346.GA30871@lunn.ch> (raw)
In-Reply-To: <20160909055351.GB26767@microsemi.com>
On Fri, Sep 09, 2016 at 11:23:52AM +0530, Raju Lakkaraju wrote:
> Hi Andrew,
>
> Thank you for review the code and valuable comments.
>
> On Thu, Sep 08, 2016 at 03:27:27PM +0200, Andrew Lunn wrote:
> > EXTERNAL EMAIL
> >
> >
> > On Thu, Sep 08, 2016 at 02:47:22PM +0530, Raju Lakkaraju wrote:
> > > From: Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>
> > >
> > > Used Device Tree to configure the MAC Interface as per review comments and
> > > re-sending code for review
> >
> > I don't see anything about device tree in this patch...
> >
> Ethernet driver (in my BBB environment, TI cpsw driver) read the device tree
> phy interface parameter and update in phydev structure.
>
> In device tree the following code holds the phy interface configuration.
> &cpsw_emac0 {
> phy_id = <&davinci_mdio>, <0>;
> phy-mode = "rgmii";
> };
O.K, that is one place it can come from. But it is not the only,
e.g. platform data or ACPI. A better comment might be:
Configure the MAC/PHY interface as indicated in phydev->interface,
eg. GMII, RMII, RGMII.
Andrew
next prev parent reply other threads:[~2016-09-09 12:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 12:20 [PATCH 1/4] net: phy: Add Edge-rate driver for Microsemi PHYs Raju Lakkaraju
2016-08-24 12:59 ` Andrew Lunn
2016-09-08 9:06 ` Raju Lakkaraju
2016-09-08 9:17 ` [PATCH v2 net-next 0/2] net: phy: Add Edge-rate, MAC-IF " Raju Lakkaraju
2016-09-08 9:17 ` [PATCH v2 net-next 1/2] net: phy: Add Edge-rate " Raju Lakkaraju
2016-09-08 13:14 ` Andrew Lunn
2016-09-09 5:40 ` Raju Lakkaraju
2016-09-09 13:18 ` Andrew Lunn
2016-09-15 10:26 ` Raju Lakkaraju
2016-09-08 9:17 ` [PATCH v2 net-next 2/2] net: phy: Add MAC-IF " Raju Lakkaraju
2016-09-08 13:27 ` Andrew Lunn
2016-09-09 5:53 ` Raju Lakkaraju
2016-09-09 12:03 ` Andrew Lunn [this message]
2016-09-15 10:28 ` Raju Lakkaraju
2016-09-08 12:59 ` [PATCH v2 net-next 0/2] net: phy: Add Edge-rate, " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909120346.GA30871@lunn.ch \
--to=andrew@lunn.ch \
--cc=Allan.Nielsen@microsemi.com \
--cc=Raju.Lakkaraju@microsemi.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.