All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/3] tests: catch ordering issue w. ether set
Date: Fri, 9 Sep 2016 15:33:16 +0200	[thread overview]
Message-ID: <20160909133316.GB24473@salvia> (raw)
In-Reply-To: <1473424996-26957-3-git-send-email-fw@strlen.de>

On Fri, Sep 09, 2016 at 02:43:15PM +0200, Florian Westphal wrote:
> Before previous commit, ether set (payload statement) was reversed on
> output:
> 
> ether daddr set 00:03:2d:2b:74:ec
> 
> would be shown as 'ec:74:2b:2d:03:00'.
> 
> With ff:ff:ff ... such bug doesn't appear so use something
> where it will show up.
> 
> Signed-off-by: Florian Westphal <fw@strlen.de>

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

  reply	other threads:[~2016-09-09 13:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 12:43 [PATCH nft 0/3] fix ether address formatting Florian Westphal
2016-09-09 12:43 ` [PATCH nft 1/3] datatype: ll: use big endian byte ordering Florian Westphal
2016-09-09 13:33   ` Pablo Neira Ayuso
2016-09-09 12:43 ` [PATCH nft 2/3] tests: catch ordering issue w. ether set Florian Westphal
2016-09-09 13:33   ` Pablo Neira Ayuso [this message]
2016-09-09 12:43 ` [PATCH nft 3/3] payload: remove byteorder conversion Florian Westphal
2016-09-09 13:34   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160909133316.GB24473@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.