From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Fri, 9 Sep 2016 16:04:13 +0200 Subject: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac In-Reply-To: <1473425117-18645-4-git-send-email-clabbe.montjoie@gmail.com> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-4-git-send-email-clabbe.montjoie@gmail.com> Message-ID: <20160909140413.GD30871@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > +The device node referenced by "phy" or "phy-handle" should be a child node > +of this node. See phy.txt for the generic PHY bindings. I've not looked at the code yet, but is this really true? Generally there is not this limitation. You can point to any Ethernet phy anyway, so long as it is on am MDIO bus. > + > +Optional properties: > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. Default is 0) > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. Default is 0) > + > +The TX/RX clock delay chain settings are board specific. > + > +Optional properties for "allwinner,sun8i-h3-emac": > +- allwinner,leds-active-low: EPHY LEDs are active low > + > +Example: > + > +emac: ethernet at 01c0b000 { > + compatible = "allwinner,sun8i-h3-emac"; > + syscon = <&syscon>; > + reg = <0x01c0b000 0x104>; > + reg-names = "emac"; > + interrupts = ; > + resets = <&ccu RST_BUS_EMAC>, <<&ccu RST_BUS_EPHY>; > + reset-names = "ahb", "ephy"; > + clocks = <&ccu CLK_BUS_EMAC>, <&ccu CLK_BUS_EPHY>; > + clock-names = "ahb", "ephy"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy = <&phy1>; ethernet.txt say: - phy: the same as "phy-handle" property, not recommended for new bindings. This is a new binding, please don't support it. > + phy-mode = "mii"; > + allwinner,leds-active-low; > + > + phy1: ethernet-phy at 1 { > + reg = <1>; > + }; It is normal to place these phy nodes inside an container node called mdio. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Date: Fri, 9 Sep 2016 16:04:13 +0200 Message-ID: <20160909140413.GD30871@lunn.ch> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-4-git-send-email-clabbe.montjoie@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1473425117-18645-4-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Corentin Labbe Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org > +The device node referenced by "phy" or "phy-handle" should be a child node > +of this node. See phy.txt for the generic PHY bindings. I've not looked at the code yet, but is this really true? Generally there is not this limitation. You can point to any Ethernet phy anyway, so long as it is on am MDIO bus. > + > +Optional properties: > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. Default is 0) > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. Default is 0) > + > +The TX/RX clock delay chain settings are board specific. > + > +Optional properties for "allwinner,sun8i-h3-emac": > +- allwinner,leds-active-low: EPHY LEDs are active low > + > +Example: > + > +emac: ethernet@01c0b000 { > + compatible = "allwinner,sun8i-h3-emac"; > + syscon = <&syscon>; > + reg = <0x01c0b000 0x104>; > + reg-names = "emac"; > + interrupts = ; > + resets = <&ccu RST_BUS_EMAC>, <<&ccu RST_BUS_EPHY>; > + reset-names = "ahb", "ephy"; > + clocks = <&ccu CLK_BUS_EMAC>, <&ccu CLK_BUS_EPHY>; > + clock-names = "ahb", "ephy"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy = <&phy1>; ethernet.txt say: - phy: the same as "phy-handle" property, not recommended for new bindings. This is a new binding, please don't support it. > + phy-mode = "mii"; > + allwinner,leds-active-low; > + > + phy1: ethernet-phy@1 { > + reg = <1>; > + }; It is normal to place these phy nodes inside an container node called mdio. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751651AbcIIOFG (ORCPT ); Fri, 9 Sep 2016 10:05:06 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:40056 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbcIIOFC (ORCPT ); Fri, 9 Sep 2016 10:05:02 -0400 Date: Fri, 9 Sep 2016 16:04:13 +0200 From: Andrew Lunn To: Corentin Labbe Cc: robh+dt@kernel.org, mark.rutland@arm.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac Message-ID: <20160909140413.GD30871@lunn.ch> References: <1473425117-18645-1-git-send-email-clabbe.montjoie@gmail.com> <1473425117-18645-4-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473425117-18645-4-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +The device node referenced by "phy" or "phy-handle" should be a child node > +of this node. See phy.txt for the generic PHY bindings. I've not looked at the code yet, but is this really true? Generally there is not this limitation. You can point to any Ethernet phy anyway, so long as it is on am MDIO bus. > + > +Optional properties: > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. Default is 0) > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. Default is 0) > + > +The TX/RX clock delay chain settings are board specific. > + > +Optional properties for "allwinner,sun8i-h3-emac": > +- allwinner,leds-active-low: EPHY LEDs are active low > + > +Example: > + > +emac: ethernet@01c0b000 { > + compatible = "allwinner,sun8i-h3-emac"; > + syscon = <&syscon>; > + reg = <0x01c0b000 0x104>; > + reg-names = "emac"; > + interrupts = ; > + resets = <&ccu RST_BUS_EMAC>, <<&ccu RST_BUS_EPHY>; > + reset-names = "ahb", "ephy"; > + clocks = <&ccu CLK_BUS_EMAC>, <&ccu CLK_BUS_EPHY>; > + clock-names = "ahb", "ephy"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy = <&phy1>; ethernet.txt say: - phy: the same as "phy-handle" property, not recommended for new bindings. This is a new binding, please don't support it. > + phy-mode = "mii"; > + allwinner,leds-active-low; > + > + phy1: ethernet-phy@1 { > + reg = <1>; > + }; It is normal to place these phy nodes inside an container node called mdio. Andrew