All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Bride <jim.bride@linux.intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 10/12] drm/i915: Update bits per component for display info
Date: Fri, 9 Sep 2016 09:58:06 -0700	[thread overview]
Message-ID: <20160909165806.GB4376@shiv> (raw)
In-Reply-To: <1473419458-17080-11-git-send-email-mika.kahola@intel.com>

On Fri, Sep 09, 2016 at 02:10:56PM +0300, Mika Kahola wrote:
> DisplayPort branch device may define max supported bits per
> component. Update display info based on this value if bpc
> is defined.
> 
> v2: cleanup to match the drm_dp_helper.c patches introduced
>     earlier in this series
> v3: Fill bpc for connector's display info in separate
>     drm_dp_helper function (Daniel)
> v4: remove updating bpc for display info as it may be overridden
>     when parsing EDID. Instead, check bpc for DP branch device
>     during compute_config
> v5: Indentation fixes (Jim Bride)
> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>

Reviewed-by: Jim Bride <jim.bride@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 16 +++++++++++++++-
>  1 file changed, 15 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 8f17c88..69cee9b 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1524,6 +1524,20 @@ void intel_dp_compute_rate(struct intel_dp *intel_dp, int port_clock,
>  	}
>  }
>  
> +int intel_dp_compute_bpp(struct intel_dp *intel_dp,
> +			 struct intel_crtc_state *pipe_config)
> +{
> +	int bpp, bpc;
> +
> +	bpp = pipe_config->pipe_bpp;
> +	bpc = drm_dp_downstream_max_bpc(intel_dp->dpcd, intel_dp->downstream_ports);
> +
> +	if (bpc > 0)
> +		bpp = min(bpp, 3*bpc);
> +
> +	return bpp;
> +}
> +
>  bool
>  intel_dp_compute_config(struct intel_encoder *encoder,
>  			struct intel_crtc_state *pipe_config,
> @@ -1590,7 +1604,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
>  
>  	/* Walk through all bpp values. Luckily they're all nicely spaced with 2
>  	 * bpc in between. */
> -	bpp = pipe_config->pipe_bpp;
> +	bpp = intel_dp_compute_bpp(intel_dp, pipe_config);
>  	if (is_edp(intel_dp)) {
>  
>  		/* Get bpp from vbt only for panels that dont have bpp in edid */
> -- 
> 2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-09-09 16:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-09 11:10 [PATCH v9 00/12] drm/i915: DP branch devices Mika Kahola
2016-09-09 11:10 ` [PATCH v9 01/12] drm: Add missing DP downstream port types Mika Kahola
2016-09-09 11:10 ` [PATCH v9 02/12] drm: Drop VGA from bpc definitions Mika Kahola
2016-09-09 11:10 ` [PATCH v9 03/12] drm: Helper to read max clock rate Mika Kahola
2016-09-09 11:10 ` [PATCH v9 04/12] drm: Helper to read max bits per component Mika Kahola
2016-09-09 11:10 ` [PATCH v9 05/12] drm: Read DP branch device id Mika Kahola
2016-09-09 11:10 ` [PATCH v9 06/12] drm/i915: Cleanup DisplayPort AUX channel initialization Mika Kahola
2016-09-09 11:10 ` [PATCH v9 07/12] drm/i915: Read DP branch device HW revision Mika Kahola
2016-09-09 11:10 ` [PATCH v9 08/12] drm/i915: Read DP branch device SW revision Mika Kahola
2016-09-09 16:57   ` Jim Bride
2016-09-09 11:10 ` [PATCH v9 09/12] drm/i915: Check pixel rate for DP to VGA dongle Mika Kahola
2016-09-09 11:10 ` [PATCH v9 10/12] drm/i915: Update bits per component for display info Mika Kahola
2016-09-09 16:58   ` Jim Bride [this message]
2016-09-09 11:10 ` [PATCH v9 11/12] drm: Add DP branch device info on debugfs Mika Kahola
2016-09-09 16:58   ` Jim Bride
2016-09-09 11:10 ` [PATCH v9 12/12] drm/i915: Check TMDS clock DP to HDMI dongle Mika Kahola
2016-09-09 12:18 ` ✓ Fi.CI.BAT: success for drm/i915: DP branch devices (rev10) Patchwork
2016-09-15 11:58 ` [Intel-gfx] [PATCH v9 00/12] drm/i915: DP branch devices Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160909165806.GB4376@shiv \
    --to=jim.bride@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=mika.kahola@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.