From: Greg Kurz <groug@kaod.org>
To: Pradeep Jagadeesh <pradeepkiruvale@gmail.com>
Cc: Alberto Garcia <berto@igalia.com>,
Claudio Fontana <claudio.fontana@huawei.com>,
qemu-devel@nongnu.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver
Date: Fri, 9 Sep 2016 17:37:17 +0200 [thread overview]
Message-ID: <20160909173717.4ed9cd13@bahia> (raw)
In-Reply-To: <20160909172916.3cefb8f2@bahia>
On Fri, 9 Sep 2016 17:29:16 +0200
Greg Kurz <groug@kaod.org> wrote:
> > +bool throttle9p_get_io_limits_state(FsThrottle *fst)
>
> The name looks a bit strange, since this helper simply returns a boolean flag.
> I guess throttle9p_enabled() is enough.
>
> > +{
> > +
> > + return fst->io_limits_enabled;
> > +}
> > +
And this could be an inline function in 9p-throttle.h.
> [...]
> > + if (!throttle_is_valid(&fst->cfg, NULL)) {
>
> You should pass an Error * to throttle_is_valid() to be able to report the
Read Error ** :)
> misconfiguration to the user. I guess it is okay to print it here using
> error_repport_err() (see include/qapi/error.h) and return -1.
>
Cheers.
--
Greg
next prev parent reply other threads:[~2016-09-09 15:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 9:10 [Qemu-devel] [PATCH v2] 9pfs: add support for IO limits to 9p-local driver Pradeep Jagadeesh
2016-09-09 12:06 ` Claudio Fontana
2016-09-09 15:29 ` Greg Kurz
2016-09-09 15:37 ` Greg Kurz [this message]
2016-09-09 15:40 ` Alberto Garcia
2016-09-12 12:52 ` Pradeep Jagadeesh
2016-09-12 14:19 ` Greg Kurz
2016-09-12 16:08 ` Pradeep Jagadeesh
2016-09-13 8:51 ` Greg Kurz
2016-09-13 9:17 ` Pradeep Jagadeesh
2016-09-13 12:30 ` Greg Kurz
2016-09-13 12:36 ` Pradeep Jagadeesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909173717.4ed9cd13@bahia \
--to=groug@kaod.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=berto@igalia.com \
--cc=claudio.fontana@huawei.com \
--cc=pradeep.jagadeesh@huawei.com \
--cc=pradeepkiruvale@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.