From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v6 00/20] Generic DT bindings for PCI IOMMUs and ARM SMMU Date: Fri, 9 Sep 2016 18:37:36 +0100 Message-ID: <20160909173736.GF11418@arm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, punit.agrawal-5wv7dgnIgG8@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org SGkgUm9iaW4sCgpPbiBUdWUsIFNlcCAwNiwgMjAxNiBhdCAwNDozMzozM1BNICswMTAwLCBSb2Jp biBNdXJwaHkgd3JvdGU6Cj4gSGVyZSdzIHY2IHRvIGFkZHJlc3MgbGFzdCB3ZWVrJ3MgY29tbWVu dHMuIEZvciB0aGUgc2FrZSBvZiBob25lc3R5IEkndmUKPiBsZWZ0IExvcmVuem8ncyB0ZXN0ZWQt Ynkgb2ZmIGV2ZXJ5dGhpbmcgSSd2ZSBjaGFuZ2VkIHNpbmNlLCBhbmQgRXJpYydzCj4gcmV2aWV3 ZWQtYnkgb2ZmIHBhdGNoIDE5IGhhdmluZyBub24tdHJpdmlhbGx5IHJld29ya2VkIHRoZSBndXRz IG9mIGl0Lgo+IAo+IFBhdGNoIDIwIGlzIG5ldywgYnV0IGFzIGl0J3MgY3VycmVudGx5IGEgc29s dXRpb24gd2FpdGluZyBmb3IgYSBwcm9ibGVtCj4gYXMgZmFyIGFzIHdlJ3JlIGF3YXJlLCBvdWdo dG4ndCB0byBnZXQgaW4gdGhlIHdheTsgaG9wZWZ1bGx5IHRoZSByZXN0IGlzCj4gaW4gZ29vZCBz aGFwZSBmb3IgNC45IG5vdy4KPiAKPiBCcmFuY2ggaGVyZSwgYmFzZWQgb24gV2lsbCdzIGlvbW11 L2RldmVsIHF1ZXVlOgo+IAo+IGdpdDovL2xpbnV4LWFybS5vcmcvbGludXgtcm0gaW9tbXUvZ2Vu ZXJpYy12NgoKSSdtIHByZXR0eSBoYXBweSB3aXRoIHRoaXMgKG1vZHVsbyB0aGUgYmluZGluZyBk b2NzIHVwZGF0ZSBldGMgd2UKZGlzY3Vzc2VkIG9mZiBsaXN0KSwgaG93ZXZlciBJJ20gc2VlaW5n IGFuIGFsbG1vZGNvbmZpZyBidWlsZCBmYWlsdXJlCndpdGggdGhpcyBhcHBsaWVkLiBFcnJvciBi ZWxvdy4KClBsZWFzZSBjYW4geW91IHRha2UgYSBsb29rIGFuZCBzZW5kIGEgZml4dXAgcGF0Y2g/ CgpDaGVlcnMsCgpXaWxsCgotLS0+OAoKSW4gZmlsZSBpbmNsdWRlZCBmcm9tIGRyaXZlcnMvZ3B1 L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYuYzozMzowOgpkcml2ZXJzL2dwdS9kcm0vZXh5bm9z L2V4eW5vc19kcm1faW9tbXUuaDogSW4gZnVuY3Rpb24g4oCYX19leHlub3NfaW9tbXVfY3JlYXRl X21hcHBpbmfigJk6CmRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9pb21tdS5oOjY5 Ojg6IGVycm9yOiB0b28gZmV3IGFyZ3VtZW50cyB0byBmdW5jdGlvbiDigJhpb21tdV9kbWFfaW5p dF9kb21haW7igJkKICByZXQgPSBpb21tdV9kbWFfaW5pdF9kb21haW4oZG9tYWluLCBzdGFydCwg c2l6ZSk7CiAgICAgICAgXgpJbiBmaWxlIGluY2x1ZGVkIGZyb20gZHJpdmVycy9ncHUvZHJtL2V4 eW5vcy9leHlub3NfZHJtX2lvbW11Lmg6NTM6MCwKICAgICAgICAgICAgICAgICBmcm9tIGRyaXZl cnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYuYzozMzoKLi9pbmNsdWRlL2xpbnV4L2Rt YS1pb21tdS5oOjMzOjU6IG5vdGU6IGRlY2xhcmVkIGhlcmUKIGludCBpb21tdV9kbWFfaW5pdF9k b21haW4oc3RydWN0IGlvbW11X2RvbWFpbiAqZG9tYWluLCBkbWFfYWRkcl90IGJhc2UsCiAgICAg XgptYWtlWzRdOiAqKiogW2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYub10g RXJyb3IgMQptYWtlWzNdOiAqKiogW2RyaXZlcnMvZ3B1L2RybS9leHlub3NdIEVycm9yIDIKbWFr ZVszXTogKioqIFdhaXRpbmcgZm9yIHVuZmluaXNoZWQgam9icy4uLi4KbWFrZVsyXTogKioqIFtk cml2ZXJzL2dwdS9kcm1dIEVycm9yIDIKbWFrZVsxXTogKioqIFtkcml2ZXJzL2dwdV0gRXJyb3Ig MgptYWtlWzFdOiAqKiogV2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgptYWtlOiAqKiog W2RyaXZlcnNdIEVycm9yIDIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24u b3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lv bW11 From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Fri, 9 Sep 2016 18:37:36 +0100 Subject: [PATCH v6 00/20] Generic DT bindings for PCI IOMMUs and ARM SMMU In-Reply-To: References: Message-ID: <20160909173736.GF11418@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Robin, On Tue, Sep 06, 2016 at 04:33:33PM +0100, Robin Murphy wrote: > Here's v6 to address last week's comments. For the sake of honesty I've > left Lorenzo's tested-by off everything I've changed since, and Eric's > reviewed-by off patch 19 having non-trivially reworked the guts of it. > > Patch 20 is new, but as it's currently a solution waiting for a problem > as far as we're aware, oughtn't to get in the way; hopefully the rest is > in good shape for 4.9 now. > > Branch here, based on Will's iommu/devel queue: > > git://linux-arm.org/linux-rm iommu/generic-v6 I'm pretty happy with this (modulo the binding docs update etc we discussed off list), however I'm seeing an allmodconfig build failure with this applied. Error below. Please can you take a look and send a fixup patch? Cheers, Will --->8 In file included from drivers/gpu/drm/exynos/exynos_drm_drv.c:33:0: drivers/gpu/drm/exynos/exynos_drm_iommu.h: In function ?__exynos_iommu_create_mapping?: drivers/gpu/drm/exynos/exynos_drm_iommu.h:69:8: error: too few arguments to function ?iommu_dma_init_domain? ret = iommu_dma_init_domain(domain, start, size); ^ In file included from drivers/gpu/drm/exynos/exynos_drm_iommu.h:53:0, from drivers/gpu/drm/exynos/exynos_drm_drv.c:33: ./include/linux/dma-iommu.h:33:5: note: declared here int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base, ^ make[4]: *** [drivers/gpu/drm/exynos/exynos_drm_drv.o] Error 1 make[3]: *** [drivers/gpu/drm/exynos] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [drivers/gpu/drm] Error 2 make[1]: *** [drivers/gpu] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2