From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biQLn-0007fq-Qo for qemu-devel@nongnu.org; Fri, 09 Sep 2016 14:16:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biQLj-0007Cx-Hj for qemu-devel@nongnu.org; Fri, 09 Sep 2016 14:16:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biQLj-0007Cr-CB for qemu-devel@nongnu.org; Fri, 09 Sep 2016 14:16:27 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F00174E4D2 for ; Fri, 9 Sep 2016 18:16:25 +0000 (UTC) Date: Fri, 9 Sep 2016 21:16:24 +0300 From: "Michael S. Tsirkin" Message-ID: <20160909211613-mutt-send-email-mst@kernel.org> References: <1473319037-27645-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473319037-27645-1-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Thu, Sep 08, 2016 at 09:17:17AM +0200, Gerd Hoffmann wrote: > We can't hotplug display adapters in qemu, tag virtio-gpu-pci > accordingly (virtio-vga already has this). > > Signed-off-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin I assume you merged this? > --- > hw/display/virtio-gpu-pci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c > index 34a724c..ef92c4a 100644 > --- a/hw/display/virtio-gpu-pci.c > +++ b/hw/display/virtio-gpu-pci.c > @@ -48,6 +48,7 @@ static void virtio_gpu_pci_class_init(ObjectClass *klass, void *data) > > set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories); > dc->props = virtio_gpu_pci_properties; > + dc->hotpluggable = false; > k->realize = virtio_gpu_pci_realize; > pcidev_k->class_id = PCI_CLASS_DISPLAY_OTHER; > } > -- > 1.8.3.1