Re: Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Sep 09, 2016 at 01:08:36PM -0400, Nicholas Krause wrote:
> 
> 
> On September 9, 2016 9:38:13 AM EDT, gregkh@linuxfoundation.org wrote:
> >
> >This is a note to let you know that I've just added the patch titled
> >
> >    [PATCH 062/135] megaraid: Fix possible NULL pointer deference in
> >
> >to the 4.4-stable tree which can be found at:
> >http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> >The filename of the patch is:
> >     0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> >and it can be found in the queue-4.4 subdirectory.
> >
> >If you, or anyone else, feels it should not be added to the stable
> >tree,
> >please let <stable@vger.kernel.org> know about it.
> >
> >
> >From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00 2001
> >From: Nicholas Krause <xerofoify@gmail.com>
> >Date: Tue, 5 Jan 2016 14:32:54 -0500
> >Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer deference
> >in
> > mraid_mm_ioctl
> >
> >[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
> >
> >This adds the needed check after the call to the function
> >mraid_mm_alloc_kioc in order to make sure that this function has not
> >returned NULL and therefore makes sure we do not deference a NULL
> >pointer if one is returned by mraid_mm_alloc_kioc.  Further more add
> >needed comments explaining that this function call can return NULL if
> >the list head is empty for the pointer passed in order to allow furture
> >users to understand this required pointer check.
> >
> >Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> >Acked-by: Sumit Saxena <sumit.saxena@avagotech.com>
> >Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
> >Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
> >Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >---
> > drivers/scsi/megaraid/megaraid_mm.c |    4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >--- a/drivers/scsi/megaraid/megaraid_mm.c
> >+++ b/drivers/scsi/megaraid/megaraid_mm.c
> >@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
> > 
> > 	/*
> > 	 * The following call will block till a kioc is available
> >+	 * or return NULL if the list head is empty for the pointer
> >+	 * of type mraid_mmapt passed to mraid_mm_alloc_kioc
> > 	 */
> > 	kioc = mraid_mm_alloc_kioc(adp);
> >+	if (!kioc)
> >+		return -ENXIO;
> > 
> > 	/*
> > 	 * User sent the old mimd_t ioctl packet. Convert it to uioc_t.
> >
> >
> >Patches currently in stable-queue which might be from
> >xerofoify@gmail.com are
> >
> >queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
> I do  not wish any of my work to
> touch the stable kernel tree.

Hahaha, sure, gladly deleted, too funny...

greg k-h