All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com,
	jingjing.wu@intel.com, mark.b.kavanagh@intel.com,
	Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure
Date: Sun, 11 Sep 2016 20:09:06 +0800	[thread overview]
Message-ID: <20160911120906.GV23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1470297529-100773-2-git-send-email-jianfeng.tan@intel.com>

On Thu, Aug 04, 2016 at 07:58:48AM +0000, Jianfeng Tan wrote:
> Based on previous fix of offload on VXLAN using i40e, applications
> need to set proper tunneling type on ol_flags so that i40e driver
> can pass it to NIC.
> 
> Fixes: a50245ede72a ("examples/tep_term: initialize VXLAN sample")
> 
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
>  examples/tep_termination/vxlan.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/examples/tep_termination/vxlan.c b/examples/tep_termination/vxlan.c
> index 5ee1f95..4bad33d 100644
> --- a/examples/tep_termination/vxlan.c
> +++ b/examples/tep_termination/vxlan.c
> @@ -237,6 +237,8 @@ encapsulation(struct rte_mbuf *m, uint8_t queue_id)
>  	m->outer_l2_len = sizeof(struct ether_hdr);
>  	m->outer_l3_len = sizeof(struct ipv4_hdr);
>  
> +	ol_flags |= PKT_TX_TUNNEL_VXLAN;
> +

Hi,

FYI, my testrobot caught some errors when this patch is applied.

	--yliu

---
x86_64-native-linuxapp-clang: config-all-yes
============================================
/root/dpdk/examples/tep_termination/vxlan.c:240:14: error: use of undeclared identifier 'PKT_TX_TUNNEL_VXLAN'
        ol_flags |= PKT_TX_TUNNEL_VXLAN;
                    ^
1 error generated.
make[1]: *** [vxlan.o] Error 1
make: *** [all] Error 2
error: build examples/tep_termination failed
error: build failed

...

  reply	other threads:[~2016-09-11 12:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04  7:58 [PATCH 0/2] Two offloading issues of tep_term Jianfeng Tan
2016-08-04  7:58 ` [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure Jianfeng Tan
2016-09-11 12:09   ` Yuanhan Liu [this message]
2016-09-12  8:42     ` Tan, Jianfeng
2016-09-12  9:36       ` Thomas Monjalon
2016-09-13  0:50         ` Tan, Jianfeng
2016-09-13  2:40         ` Yuanhan Liu
2016-08-04  7:58 ` [PATCH 2/2] examples/tep_term: fix inner L4 checksum failure Jianfeng Tan
2016-10-13  9:39 ` [PATCH 0/2] Two offloading issues of tep_term Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160911120906.GV23158@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=mark.b.kavanagh@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.