From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Stephen Hurd <stephen.hurd@broadcom.com>
Subject: Re: [PATCH] net/bnxt: make driver less verbose
Date: Sun, 11 Sep 2016 20:25:39 +0800 [thread overview]
Message-ID: <20160911122539.GA23158@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1472123147-22997-1-git-send-email-ferruh.yigit@intel.com>
On Thu, Aug 25, 2016 at 12:05:47PM +0100, Ferruh Yigit wrote:
> This line printed for every application even if driver is not used at
> all. Removing the line to reduce the noise.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 3795fac..37d0322 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd = {
>
> static int bnxt_rte_pmd_init(const char *name, const char *params __rte_unused)
> {
> - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name);
Hi,
FYI, my testrobot caught some errors when this patch is applied.
--yliu
---
/root/dpdk/drivers/net/bnxt/bnxt_ethdev.c:1057:42: error: unused parameter 'name' [-Werror,-Wunused-parameter]
static int bnxt_rte_pmd_init(const char *name, const char *params __rte_unused)
^
1 error generated.
make[6]: *** [bnxt_ethdev.o] Error 1
make[5]: *** [bnxt] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [net] Error 2
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2
error: build failed
next prev parent reply other threads:[~2016-09-11 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 11:05 [PATCH] net/bnxt: make driver less verbose Ferruh Yigit
2016-08-25 19:03 ` Ajit Khaparde
2016-08-26 8:39 ` Ferruh Yigit
2016-08-26 15:31 ` Ajit Khaparde
2016-09-11 12:25 ` Yuanhan Liu [this message]
2016-09-12 14:23 ` [PATCH v2] " Ferruh Yigit
2016-09-19 15:04 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160911122539.GA23158@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen.hurd@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.