Re: [PATCH 1/1] tpm/tpm-dev: fix broken style in copy_from_user

[Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

On Sun, Sep 11, 2016 at 10:22:10PM +0300, Tomas Winkler wrote:
> Straighten unneeded line brake and drop useless cast to void.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Thanks.

Acked-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>

/Jarkko

> ---
>  drivers/char/tpm/tpm-dev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm-dev.c b/drivers/char/tpm/tpm-dev.c
> index 912ad30be585..9782df406345 100644
> --- a/drivers/char/tpm/tpm-dev.c
> +++ b/drivers/char/tpm/tpm-dev.c
> @@ -130,8 +130,7 @@ static ssize_t tpm_write(struct file *file, const char __user *buf,
>  
>  	mutex_lock(&priv->buffer_mutex);
>  
> -	if (copy_from_user
> -	    (priv->data_buffer, (void __user *) buf, in_size)) {
> +	if (copy_from_user(priv->data_buffer, buf, in_size)) {
>  		mutex_unlock(&priv->buffer_mutex);
>  		return -EFAULT;
>  	}
> -- 
> 2.7.4
> 

------------------------------------------------------------------------------