From: Florian Westphal <fw@strlen.de>
To: Liping Zhang <zlpnobody@163.com>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
Liping Zhang <liping.zhang@spreadtrum.com>
Subject: Re: [PATCH nft] tests: py: replace "eth0" with "lo" in dup expr tests
Date: Mon, 12 Sep 2016 02:43:17 +0200 [thread overview]
Message-ID: <20160912004317.GA27566@breakpoint.cc> (raw)
In-Reply-To: <1473495243-39716-1-git-send-email-zlpnobody@163.com>
Liping Zhang <zlpnobody@163.com> wrote:
> From: Liping Zhang <liping.zhang@spreadtrum.com>
>
> This patch follow up on Manuel's commit a8871ba6daa0 ("tests: py: any:
> Make tests more generic by using other interfaces"). The ifindex of
> "eth0" is not always 1, furthermore, "eth0" maybe not exist on some
> systems. So replace it with "lo" will make tests more rubost.
>
> In other test cases, "eth0" is used by iifname or oifname, so there's no
> need to convert it to "lo". Even if "eth0" is not exist, test will never
> fail.
Applied, thanks.
prev parent reply other threads:[~2016-09-12 0:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 8:14 [PATCH nft] tests: py: replace "eth0" with "lo" in dup expr tests Liping Zhang
2016-09-12 0:43 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912004317.GA27566@breakpoint.cc \
--to=fw@strlen.de \
--cc=liping.zhang@spreadtrum.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.