From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjG4n-0006h2-IG for qemu-devel@nongnu.org; Sun, 11 Sep 2016 21:30:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjG4i-0005ga-Ag for qemu-devel@nongnu.org; Sun, 11 Sep 2016 21:30:24 -0400 Date: Mon, 12 Sep 2016 11:27:57 +1000 From: David Gibson Message-ID: <20160912012757.GE12621@voom.fritz.box> References: <1473167877-2545-1-git-send-email-lvivier@redhat.com> <1473167877-2545-3-git-send-email-lvivier@redhat.com> <20160908020423.GD3883@voom.fritz.box> <19b24b76-5650-74de-6870-f6a8bc3f5e12@redhat.com> <20160909142545.4876b85e@bahia> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YkJPYEFdoxh/AXLE" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 2/3] tests: make pc_alloc_init/init_flags/uninit generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: Greg Kurz , thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org --YkJPYEFdoxh/AXLE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 09, 2016 at 02:31:55PM +0200, Laurent Vivier wrote: >=20 >=20 > On 09/09/2016 14:25, Greg Kurz wrote: > > On Thu, 8 Sep 2016 09:50:31 +0200 > > Laurent Vivier wrote: > >=20 > >> On 08/09/2016 04:04, David Gibson wrote: > >>> On Tue, Sep 06, 2016 at 03:17:56PM +0200, Laurent Vivier wrote: =20 > >>>> And add support for ppc64. > >>>> > >>>> Signed-off-by: Laurent Vivier =20 > >>> > >>> Some of my coments may be obsoleted by the discussion with Greg. > >>> =20 > >>>> --- > >>>> v2: > >>>> - remove useless parenthesis, inline > >> [...] > >>>> + > >>>> +QGuestAllocator *machine_alloc_init(void) > >>>> +{ > >>>> + const char *arch =3D qtest_get_arch(); =20 > >>> > >>> Maybe we need to add a qtest_get_machine_type(). =20 > >> > >> I'm working on that... > >> > >=20 > > The problem is that qtest only knows about archs, based on $(TARGETS). > > Maybe the machine type could be the default one for a given arch ? >=20 > Once the machine is started we can use QMP[1] to ask the machine type > (for instance, "pseries-2.7-machine"). >=20 > So what we could do is a generic qtest_machine_vboot() which ask the > machine type and configure the qtest framework accordingly. >=20 > Laurent > [1] { 'execute': 'qom-get', 'arguments': { 'path': '/machine', > 'property': 'type' } } Ok.. doesn't the qtest framework start the machine though? So it should already know the machine type, shouldn't it? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --YkJPYEFdoxh/AXLE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJX1gSdAAoJEGw4ysog2bOS+rkQAKo/nQxl56RphbOfD1Y0SI2x XD+z7fk2p4X1FPq+PgvN8xOMnBTgXdhVvynrJNDz27p+Ckl5tARCANiLfiafm7qk MWhzJZDmij1+CtvuVBquk3UCgimTnfgNekQghX2S3yqs5vRn+mwUQlWqtDthbJKr NYaZAYSCfl9clYwlgiXDa760AfyATdggXM7QelvIugO2RICMSccXfTJxkDx0Dryf wi8x7slW+ZWScHdBq1ypPeiSFP8SXeMVxsJSxjq2j0rTFr6I00Qa+beJey6FPkGn UdFIEmkkLVJHNcym/5w+mRMkFezOjjBpg6O4RZU93z/vS5ZeXLdsm5ox5ii/Yuxr E4ovfehxMfCEfp4bUPHRUrL4/3j98qHq8WQX9Qs5z30GK4oVqR+usCnSCN44B3me KlLJ3qEzIQYgIs7kDfOtMWYXECfHH7gV8In81pcnzk2AxBABXAuFcaz9DJvDCFsi aDvUQO55JCbY/LuSQi+/sygxkl0ISK4UaLI1mbBYbS4hwtfAdciWsWVx9vQS5VVD G3xyW8NU/bFZNwcrnq21Nq9cmRowoLVKTgKsWvNs/Vo1idljLjayC0ETINENHV12 bWZNl1jqAzbv1VvwWkPOx+NU/7P10sMBwywOA+R/ZJr+6GkZ8fp9bnY3Oth6M4Nq R5CUvFxKvBZ2pbbHpaV7 =kdnz -----END PGP SIGNATURE----- --YkJPYEFdoxh/AXLE--